-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHARED DEV] [#162345] Allow facility staff to upload file to order for cross core #4482
Conversation
I don't understand the data model enough to know what the fix is but It looks to me like the [skipped test you linked to](this one) might be part of a bug. It redirect to a URL like As I looked more, I noticed that the fixture named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeticiaErrandonea is the issue with the specs, or behavior of the application?
I think there is value in specs that document the behavior, even if the behavior is not ideal - like redirecting to a 404 page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small formatting changes.
Are you going to change the default wait time in a separate PR?
Release Notes
Additional Context
Tried to add specs here but I run into the same problem as with this one we ended up skipping.