Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHARED DEV] [#162345] Allow facility staff to upload file to order for cross core #4482

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

LeticiaErrandonea
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea commented Aug 7, 2024

Release Notes

  • Fix file upload for cross core orders

Additional Context

Tried to add specs here but I run into the same problem as with this one we ended up skipping.

@annaswims
Copy link

I don't understand the data model enough to know what the fix is but It looks to me like the [skipped test you linked to](this one) might be part of a bug.

It redirect to a URL like http://172.18.0.5:4000/facilities/facility5/orders/2612 ... but order is not associated with the facility5.

As I looked more, I noticed that the fixture named facility2 has url_name: "facility5" and the fixture named facility has url_name: "facility2".

Copy link
Collaborator

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeticiaErrandonea is the issue with the specs, or behavior of the application?
I think there is value in specs that document the behavior, even if the behavior is not ideal - like redirecting to a 404 page.

Copy link
Collaborator

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small formatting changes.
Are you going to change the default wait time in a separate PR?

app/assets/javascripts/app/order_table_refresh.js Outdated Show resolved Hide resolved
app/controllers/facility_orders_controller.rb Outdated Show resolved Hide resolved
app/lib/ability.rb Outdated Show resolved Hide resolved
app/views/facility_orders/show.html.haml Outdated Show resolved Hide resolved
app/views/facility_orders/show.html.haml Outdated Show resolved Hide resolved
@LeticiaErrandonea LeticiaErrandonea merged commit ce51952 into master Aug 14, 2024
3 checks passed
@LeticiaErrandonea LeticiaErrandonea deleted the 162345-fix_redirection branch August 14, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants