Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#162433] Tech task: fix capybara warnings on selector types #4641

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

joaquinco
Copy link
Collaborator

Notes

Clean up capybara spec warnings by converting ids to strings when using them as selectors in matchers.

@joaquinco joaquinco requested a review from a team as a code owner October 14, 2024 20:21
Copy link
Collaborator

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Two small requests:

  • Can you add a ticket number in the title?
  • We have a release script that sorts the PRs based on the title. If it includes "tech task" then it's considered as such. Can you remove the hyphen in the title?

@joaquinco joaquinco changed the title [Tech-Task] Fix capybara warnings on selector types [#162433] Tech-Task: fix capybara warnings on selector types Oct 15, 2024
@joaquinco joaquinco changed the title [#162433] Tech-Task: fix capybara warnings on selector types [#162433] Tech task: fix capybara warnings on selector types Oct 15, 2024
@joaquinco joaquinco merged commit c3ea716 into master Oct 15, 2024
3 checks passed
@joaquinco joaquinco deleted the tech-task/fix-capybara-warngins branch October 15, 2024 13:53
joaquinco added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants