Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with current state of initialization #11

Merged
merged 4 commits into from
May 30, 2022
Merged

Update README with current state of initialization #11

merged 4 commits into from
May 30, 2022

Conversation

miry
Copy link
Contributor

@miry miry commented May 26, 2022 •
edited
Loading

  1. Example from README.md for shards.yml ended with error message:
Error shard name (opentelemetry-api) doesn't match dependency name (otel)
  1. Exporter initialization is different in readme from current state:
 16 | config.exporter = OpenTelemetry::IOExporter.new(:STDOUT)
                        ^------------------------
Error: undefined constant OpenTelemetry::IOExporter

@miry miry marked this pull request as ready for review May 26, 2022 21:35
@miry miry changed the title Update shards example to have name as library Update README with current state of initialization May 27, 2022
@wyhaines wyhaines merged commit bfde005 into wyhaines:main May 30, 2022
@miry miry deleted the update-readme branch May 30, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miry @wyhaines