Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognizer check fails on direct reference comparison #56

Open
booleanbetrayal opened this issue Sep 13, 2018 · 0 comments
Open

Recognizer check fails on direct reference comparison #56

booleanbetrayal opened this issue Sep 13, 2018 · 0 comments

Comments

@booleanbetrayal
Copy link
Contributor

booleanbetrayal commented Sep 13, 2018 •
edited
Loading

I'm seeing the following after upgrading an older project's angular-gestures package to include the new recognizer check added via #41 . Specifically, the line where the direct function reference comparison is made. You can see in this debug output that there is a PanRecognizer defined (2nd entry) but it fails the comparison.

screen shot 2018-09-13 at 12 09 17 pm

I'm including hammer.js and angular-gestures.js once, so I'm not sure what's creating this reference difference. Maybe making it more resilient by relying on the function name property instead makes sense though?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@booleanbetrayal