Add a check to validate the recognizers configuration for the directives... #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzr1337
added a commit
that referenced
this pull request
May 15, 2015
fix(recognizers): Add a check to validate the recognizers configuration for the directives...
|
awesome, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent almost one hour trying to find out why the hm-swipe directive wasn't working in my example, until I found that I needed to configure the
Hammer.Swiperecognizer because angular-gestures is using theHammer.Managerconstructor (which has no default recognizer).So, I though it would be nice to have angular-gestures throw if the needed recognizer is not configured.