Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fixed pages #78

Merged
merged 2 commits into from
Oct 8, 2023
Merged

support fixed pages #78

merged 2 commits into from
Oct 8, 2023

Conversation

Songmu
Copy link
Member

@Songmu Songmu commented Oct 8, 2023

resolve #60

元々の挙動としてブログ記事は entry/ 配下に配置される。そして、このpull requestでは固定ページは、localRoot 直下に配置されるようになった。つまり page/ などのディレクトリを掘ってそこに配置するようにはしなかったということ。具体的には以下のような感じ

.
├── entry
│   ├── entry1.md
│   └── entry2.md
├── page1.md
└── page2.md

page/ を掘らなかった理由としては

  • 公開URLと階層構造が同じになるので分かりやすい
  • ブログメディアでサブディレクトリ運用にしている場合に page をどう掘るかが難しい
    • 例えば、 example.com/subdirblog/ とかの場合、現状 ./subdirblog/entry/entry1.md とかにpullされる

というのがある

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6447861847

  • 0 of 27 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 27.113%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
broker.go 0 26 0.0%
Files with Coverage Reduction New Missed Lines %
broker.go 2 4.65%
Totals Coverage Status
Change from base Build 6447608030: -0.8%
Covered Lines: 170
Relevant Lines: 627

💛 - Coveralls

@Songmu Songmu added the minor label Oct 8, 2023
@Songmu Songmu requested a review from motemen October 8, 2023 15:54
@Songmu Songmu merged commit 15a9f3e into master Oct 8, 2023
7 checks passed
@Songmu Songmu deleted the page branch October 8, 2023 16:41
@github-actions github-actions bot mentioned this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing fixed pages (固定ページ)
2 participants