fix: fix cache invalidation (#437)

x1unix · Oct 6, 2024 · a5c99ab · a5c99ab
1 parent e8bb79b
commit a5c99ab
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/web/src/services/storage/kv.ts b/web/src/services/storage/kv.ts
@@ -1,17 +1,24 @@
 import { isAfter } from 'date-fns'
 import type { DatabaseStorage } from './db'
-import type { CacheStorage } from './types'
+import type { CacheEntry, CacheStorage } from './types'
+
+type RecordValidator<T> = (entry: CacheEntry<T>) => boolean
 
 export class KeyValueStore implements CacheStorage {
   constructor(private readonly db: DatabaseStorage) {}
 
-  async getItem<T>(key: string): Promise<T | undefined> {
+  async getItem<T>(key: string, validate?: RecordValidator<T>): Promise<T | undefined> {
     const entry = await this.db.keyValue.get(key)
     if (entry?.expireAt && isAfter(new Date(), entry.expireAt)) {
       void this.deleteItem(key)
       return undefined
     }
 
+    if (entry && validate && !validate(entry)) {
+      void this.deleteItem(key)
+      return undefined
+    }
+
     return entry?.value as T | undefined
   }
 

diff --git a/web/src/workers/language/language.worker.ts b/web/src/workers/language/language.worker.ts
@@ -158,7 +158,11 @@ export class WorkerHandler {
     }
 
     // TODO: add invalidation by Go version
-    const version = await this.keyValue.getItem<string>(completionVersionKey)
+    const version = await this.keyValue.getItem<string>(completionVersionKey, (entry) => {
+      // v2.2.0 didn't write TTL by mistake
+      return typeof entry.expireAt !== 'undefined'
+    })
+
     if (!version) {
       await this.populateCache()
       return true