Do not crash on devices without a LinkKey #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a bluetooth device does not have a LinkKey, for example if it does not support pairing, then the current code would crash with an unknown section error. This fixes that by handling that case gracefully and showing those devices in a separate list to make it clear that these are not relevant for this project.
|
Thank you for contribution! |
|
the works perfectly on my device, should be merged to main |
|
It does at least allow me to see the other devices... but for me, the ones with no pairing key are BLE devices, and it would be great if this tool could support them. There's info and another script linked from here... but that script claims to work in the other direction. Would be nice to be able to push the Linux keys to Windows for BLE devices. |
|
It seems like these are BT 5.1 devices. I've create an implementation at #14 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bluetooth device does not have a LinkKey, for example if it does
not support pairing, then the current code would crash with an unknown
section error.
This fixes that by handling that case gracefully and showing those
devices in a separate list to make it clear that these are not relevant
for this project.