Fixed regression in processing IfcEdgeCurve with same EdgeStart and EdgeEnd #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://standards.buildingsmart.org/IFC/RELEASE/IFC4/ADD2_TC1/HTML/schema/ifctopologyresource/lexical/ifcedge.htm
![comparing-ifcvalve-using-ifcedgecurve-with-same-start-and-end](https://private-user-images.githubusercontent.com/61967085/239471925-397833c6-d1e4-4ed3-9ac1-6ff2c9dd18d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNTgyMDIsIm5iZiI6MTcyNjE1NzkwMiwicGF0aCI6Ii82MTk2NzA4NS8yMzk0NzE5MjUtMzk3ODMzYzYtZDFlNC00ZWQzLTlhYzEtNmZmMmM5ZGQxOGQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2MTgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkMWVhM2EyMmEzNTllNmE0NTk3MTExMWM0MzBhZTdhYmMzZDRkY2UyNTNkMTgxYjdiNDRiZDI2YzA0ZjQyYTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0fzKuc1fBpu9ntIVeU4Ud-dAS43XvMRHdPByxJQlkvE)
in "Attribute Definitions", for param 2 "EdgeEnd": The same vertex can be used for both EdgeStart and EdgeEnd.
This appears to be a regression comparing to older versions of this function (InitAdvancedFaces) which uses XbimEdge to do the trimming and handled this situation.