WAV Player: Reconfigure to use 8-bit memory buffer, halving memory usage #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Willy-JL
added a commit
to Next-Flip/Momentum-Apps
that referenced
this pull request
Jul 3, 2024
xMasterX/all-the-plugins#156 Co-authored-by: CookiePLMonster <CookiePLMonster@users.noreply.github.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WAV Player configures the memory side of the DMA transfer to halfword (16 bits), even though the end result of the WAV decoding is always within the
u8range. This PR modifies the transfer config to byte (8 bits), as STM32WB55 specifically allows to mismatch memory and peripheral data sizes.This effectively reduces the memory usage of the app by approximately 1/3 (16bit buffer + 8bit buffer -> 8bit buffer + 8bit buffer).