Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Rename Datapoints #2

Closed
KoMa1978 opened this issue Jan 30, 2023 · 12 comments
Closed

[Feature]: Rename Datapoints #2

KoMa1978 opened this issue Jan 30, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@KoMa1978
Copy link

Is your feature request related to a problem? Please describe.

Please rename the datapoints from "datapoint" to "<<keylight / Info / Displayname>> - datapoint" example
Now: "Brightness"
Wanted: "Keylight Links - Brightness"

It is hard to understand a script if there are multiple keylights I want to control.

image

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@KoMa1978 KoMa1978 added the enhancement New feature or request label Jan 30, 2023
@xXBJXx
Copy link
Owner

xXBJXx commented Feb 6, 2023

is it enough if i do this only for the light.lights? or should this be done for all states
image

@KoMa1978
Copy link
Author

KoMa1978 commented Feb 6, 2023

Hmm,

I would prefer to have all data points named similar.
If I look at my other objects, like HomeMatic, all the datapoints start with the "DeviceName" then a "." and the the datapoint:
image
I think this is the most flexible way.

@xXBJXx
Copy link
Owner

xXBJXx commented Feb 6, 2023

Please install from GitHub and try if it fits like this

xXBJXx added a commit that referenced this issue Feb 6, 2023
* (xXBJXx) removed the Bonjour search, because it did not work properly
* (xXBJXx) Adding a delete function for devices
* (xXBJXx) Dependency updates
* (xXBJXx) feature request [#2](#2) added
xXBJXx added a commit that referenced this issue Feb 6, 2023
* (xXBJXx) removed the Bonjour search, because it did not work properly
* (xXBJXx) Adding a delete function for devices
* (xXBJXx) Dependency updates
* (xXBJXx) feature request [#2](#2) added
@KoMa1978
Copy link
Author

KoMa1978 commented Feb 6, 2023

Looks very good! Thanks a lot!

There are some datapoints (maybe old ones) without the name and the folders have no name included ... OK not really needed but will look better ;-)

Just a personal opinion: I think a "." or "_" as separator between the devicename and datapoint would be better.

image

Again thanks a lot!! You should add this adapter to the default iobroker repository.

@xXBJXx
Copy link
Owner

xXBJXx commented Feb 6, 2023

The folder names I can also still adapt, and "." or "_" I can also still make.
The adapter will also be added to the ioBroker repo, but it has to run and be tested for a few weeks.

I will make the request in a few days after that, it will take a few weeks until the adapter is tested, and possible bugs are fixed.

@xXBJXx
Copy link
Owner

xXBJXx commented Feb 6, 2023

The state name does not exist any more, you can delete it

@KoMa1978
Copy link
Author

KoMa1978 commented Feb 6, 2023

Great work!! Again!! Works much better than my Javasrcipts ;-)
I used a couple of days to turn on/of my video lights with a HomeMatic Switch and it very reliable.

@xXBJXx
Copy link
Owner

xXBJXx commented Feb 6, 2023

so the "." and "_" doesn't look so good, because the states also have names from more words e.g.
elgato-key-light.0.EW40K1A09882.info.firmwareBuildNumber
that looks like Elgato Light Strip Test_Firmware Build Number Elgato Light Strip Test.Firmware Build Number.
I could possibly add a "/", that looks a little better => Elgato Light Strip Test / Firmware Build Number.

@KoMa1978
Copy link
Author

KoMa1978 commented Feb 6, 2023

Yes you are right, a „/„ looks better.

at least everything different from a whitespace makes it much clearer that it is a separator

xXBJXx added a commit that referenced this issue Feb 6, 2023
@xXBJXx
Copy link
Owner

xXBJXx commented Feb 6, 2023

Have adjusted it, please check

@KoMa1978
Copy link
Author

KoMa1978 commented Feb 7, 2023

Niiiiiiiicccee ;-)

What I've seen is that the datapoint names are first letter uppercase for data points but not for folders.

And regarding the folders, does it make sense to name them "Name / Folder / Datapoint" (example: "Key Light RECHTS / Wifi-Info / SSID"?

image

Yes at the moment there are only unique names but I don't know if the other Elgato devices have subfolders with identical datapoint names, like lights.0 and lights.1:

image

Not needed by me, but maybe simply use the provided folder structure like "Key Light RECHTS / Light / Lights / 0 / Brighness" is more futureproof?

Thanks again for the great adapter!

@xXBJXx
Copy link
Owner

xXBJXx commented Feb 26, 2023

Not needed by me, but maybe simply use the provided folder structure like "Key Light RECHTS / Light / Lights / 0 / Brighness" is more futureproof?

I won't do that with the path of the state in the name because that only drags out the name, and then you can't leave it under the objects anymore.

I close the topic, if there is something else you can open it again

@xXBJXx xXBJXx closed this as completed Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants