replay-test: fix multi-module-app test

- move "play.plugins" back to "app" where it was in Play1
- modify BaseSpec to actually run "HelloWorldApp" instead of the Starter
helper class

replay-tests/multi-module-app/core/src/main/resources/conf/play.plugins

README.md

@@ -215,7 +215,7 @@ Where this is possible the guide below points this out with a **TIP**.
 The following list breaks down the porting effort into tasks:
 
 * Port the dependency specification from `conf/dependencies.yml` (Ivy2 format) to `build.gradle` (Gradle format).
-* Move `app/play.plugins` to `conf/` and add all plugins you need explicitly (see the section on "Plugins").
+* Ensure that `app/play.plugins` file (or the file where the `play.plugins.descriptor` configuration property is pointing) is on the classpath (e.g. `sourceSets.main.resources { srcDir 'app' }`) and add all plugins you need explicitly (see the section on "Plugins").
 * Add the `app/<appname>/Application.java` and `app/<appname>/Module.java` (see the
 [RePlay example project](/Users/andrei/projects/replay/replay-tests/criminals) for inspiration). 
 * Play1's [`PropertiesEnhancer`](https://github.com/playframework/play1/blob/master/framework/src/play/classloading/enhancers/PropertiesEnhancer.java) was removed.

replay-tests/multi-module-app/app/app/hello/HelloWorldApp.java

@@ -0,0 +1,12 @@
+package hello;
+
+import play.server.Starter;
+
+public class HelloWorldApp {
+  public int start(String playId) {
+    return Starter.start(playId);
+  }
+  public static void main(String[] args) {
+    new HelloWorldApp().start(System.getProperty("play.id", "prod"));
+  }
+}

replay-tests/multi-module-app/app/test/ui/hello/BaseSpec.java

@@ -1,9 +1,9 @@
 package ui.hello;
 
 import com.codeborne.selenide.Configuration;
+import hello.HelloWorldApp;
 import org.junit.jupiter.api.BeforeEach;
 import play.Play;
-import play.server.Starter;
 
 import java.util.concurrent.atomic.AtomicBoolean;
 
@@ -20,7 +20,7 @@ public void setUp() {
   private static synchronized void startApp() {
     if (appStarted.get()) return;
 
-    int port = Starter.start("test");
+    int port = new HelloWorldApp().start("test");
 
     Configuration.baseUrl = "http://localhost:" + port;
     Play.configuration.setProperty("application.baseUrl", Configuration.baseUrl);