installreferrer bindings #556

moljac · 2022-05-18T07:06:20Z

Does this change any of the generated binding API's?

Yes - new bindings.

extracted from: #468

Describe your contribution

bound
- com.android.installreferrer:installreferrer - -> 1.0

config.json

source/com.android.installreferrer/installreferrer/Transforms/Metadata.Namespaces.xml

moljac · 2022-05-24T06:42:22Z

/azp run

azure-pipelines · 2022-05-24T06:42:33Z

Azure Pipelines successfully started running 1 pipeline(s).

jpobst · 2022-05-26T13:29:27Z

config.json

+        "artifactId": "installreferrer",
+        "version": "1.0",
+        "nugetVersion": "1.0.0",
+        "nugetId": "Xamarin.Google.Android.Installreferrer",


Capitalization: InstallReferrer

jpobst · 2022-05-26T13:44:09Z

source/com.android.installreferrer/installreferrer/Transforms/Metadata.Namespaces.xml

@@ -0,0 +1,27 @@
+<metadata>


With #555 committed, this file should be deleted, and replaced with the following lines in Directory.Build.props:

<AndroidNamespaceReplacement Include='com.android.' Replacement='Xamarin.Android' />

com.google.android.finsky.externalreferrer -> Xamarin.Google.Android.Finsky.ExternalReferrer - This one is a little more difficult because our other libraries do not append Xamarin before Google for the `com.google.android' namespace. For example:

Google.Android.Material.Animation

If we want to use Xamarin.Google.Android, we will need to add:

<AndroidNamespaceReplacement Include='com.google.android.' Replacement='Xamarin.Google.Android' />

It will need to be added before this existing line so that it is run first:

<AndroidNamespaceReplacement Include='com.google.' Replacement='Google' />

I can support it either way:

Google.Android.Finsky.ExternalReferrer to be consistent with Material

Xamarin.Google.Android.Finsky.ExternalReferrer because we really should have Xamarin in our namespaces so it doesn't conflict with anyone else's packages

🤷

Am I not allowed to change namespaces "old way" (with metadata)?

In general, the new way is less work. It would require no work in most new cases. This particular one requires 2 lines the way as opposed to 4 lines the old way.

The new way also runs faster in generator, making builds faster.

Now, just for changing namespaces we have 2 ways of doing it

XPath/XML

MSBuild

In a spirit of "growth mindset" let us further grow number of options to fix namespaces with:

Roslyn analyzers

Source generators

Just to make bindings more approachable for users and technology acceptance. Bindings are trivial and everybody does it just for fun and users are thrilled with alternatives. The more options the better and users will benefit by being forced to learn, just they don't know that. Options never raise questions and express freedom and inclusiveness.

Pro argument for MsBuild approach I recently heard: "new (MSBuild )way is centrally managed".

We have central metadata files in both AX and GPS-FB-MLKit which could be used for central management of namespaces.

Now, performance. I accept that MsBuild approach might be faster than XPath, but we have other problems, like hundreds if not thousands of matched no node which slow down builds, etc etc.

For the record:

dotnet/java-interop#727 (comment)

As you said here: xamarin/GooglePlayServicesComponents#636 (comment):

Options do not hurt.

😉

A little bit if the PR is not approved for using "other way" or "old way".

jpobst · 2022-05-26T13:53:23Z

templates/installreferrer/External-Dependency-Info.txt

+
+
+
+                                 Apache License


This library does not appear to be licensed under Apache 2.0: https://maven.google.com/web/index.html?q=g#com.android.installreferrer:installreferrer:2.2

It appears to be licensed under the Android Software Development Kit License. I suspect that this license does not allow us to redistribute the .aar file, and we will need to use Xamarin.Build.Download for this package:

Except to the extent required by applicable third party licenses, you may not copy (except for backup purposes), modify, adapt, redistribute, decompile, reverse engineer, disassemble, or create derivative works of the SDK or any part of the SDK.

version 1.0 is under Apache.

They changed it in version 1.1.

Let us bind and release version 1.0, so Facebook components are unblocked.

I ran over this issue (license varying across versions) during cgmanifest.json generation. I came up with some sort of solution, but writing tons of if-then-else will be nearly manual job, which is also not desireable.

jpobst · 2022-05-26T13:53:44Z

templates/installreferrer/License.md

@@ -0,0 +1,15 @@
+**Xamarin is not responsible for, nor does it grant any licenses to, third-party packages. Some packages may require or install dependencies which are governed by additional licenses.**
+
+Note: This component depends on [com.android.installreferrer:installrefererrer](https://maven.google.com/web/index.html?q=installreferrer#com.android.installreferrer:installreferrer), which is subject to the [Apache 2.0](https://developer.android.com/google/play/installreferrer/)


!Apache 2.0

version 1.0 is Apache 2.0

https://maven.google.com/web/index.html?q=install#com.android.installreferrer:installreferrer:1.0

templates/installreferrer/Project.cshtml

jpobst · 2022-05-26T13:57:37Z

templates/installreferrer/Project.cshtml

+    <Authors>Microsoft</Authors>
+    <Owners>Microsoft</Owners>
+    <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
+    <PackageProjectUrl>https://go.microsoft.com/fwlink/?linkid=2091414</PackageProjectUrl>


Remove <PackageProjectUrl>/<PackageRequireLicenseAcceptance> so it picks up the ones in Directory.Build.props.

There likely isn't a <PackageLicenseExpression> for this license, since it isn't open source. We should use <PackageLicense> instead of the deprecated <PackageLicenseUrl>. (https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-a-license-expression-or-a-license-file)

jpobst · 2022-05-26T13:57:58Z

templates/installreferrer/Project.cshtml

+  </ItemGroup>
+
+  <ItemGroup>
+    <None Include="..\..\templates\auto-value\License.md" Pack="true" PackagePath="License.md" />


!auto-value

jpobst · 2022-05-26T13:58:29Z

utilities.cake

@@ -214,6 +214,7 @@ Task ("spell-check")
 		        "J2Objc",
 		        "CheckerFramework",
 		        "CheckerQual",
+                "Installreferrer",


Capitalization: InstallReferrer.

…rin/AndroidX into mu-20220518-installreferrer

moljac · 2022-07-22T10:47:36Z

This PR needs to only contain changes related to InstallReferrer bindings. Currently, this seems to include changes from many other open PRs. (155 files changed.)

well not anymore - 16

moljac · 2022-07-22T10:47:50Z

/azp run

azure-pipelines · 2022-07-22T10:48:03Z

Azure Pipelines successfully started running 1 pipeline(s).

moljac · 2022-07-23T08:17:21Z

samples build error ACW generation (note net6 only):

obj/Release/net6.0-android/android/src/mono/com/android/installreferrer/api/InstallReferrerStateListenerImplementor.java(8,34): javac error JAVAC0000:  error: package com.android.installreferrer.api does not exist [./samples/dotnet/BuildAllDotNet/BuildAllDotNet.csproj]
obj/Release/net6.0-android/android/src/mono/com/android/installreferrer/api/InstallReferrerStateListenerImplementor.java(8,34): javac error JAVAC0000: 		com.android.installreferrer.api.InstallReferrerStateListener [./samples/dotnet/BuildAllDotNet/BuildAllDotNet.csproj]
obj/Release/net6.0-android/android/src/mono/com/android/installreferrer/api/InstallReferrerStateListenerImplementor.java(8,34): javac error JAVAC0000:  [./samples/dotnet/BuildAllDotNet/BuildAllDotNet.csproj]

 ll ./generated/com.android.installreferrer.installreferrer/obj/Debug/monoandroid12.0/generated/src

api.xml

    <interface abstract="true" deprecated="not deprecated" final="false" name="InstallReferrerStateListener" static="false" visibility="public" jni-signature="Lcom/android/installreferrer/api/InstallReferrerStateListener;">
      <method abstract="true" deprecated="not deprecated" final="false" name="onInstallReferrerServiceDisconnected" jni-signature="()V" bridge="false" native="false" return="void" jni-return="V" static="false" synchronized="false" synthetic="false" visibility="public" />
      <method abstract="true" deprecated="not deprecated" final="false" name="onInstallReferrerSetupFinished" jni-signature="(I)V" bridge="false" native="false" return="void" jni-return="V" static="false" synchronized="false" synthetic="false" visibility="public">
        <parameter name="p0" type="int" jni-type="I" />
      </method>
    </interface>

MCWs:

total 224
drwxr-xr-x  13  wheel    416 Jul 23 09:35 .
drwxr-xr-x   7  wheel    224 Jul 23 09:35 ..
-rw-r--r--   1  wheel   3865 Jul 23 09:35 Java.Interop.__TypeRegistrations.cs
-rw-r--r--   1  wheel   8680 Jul 23 09:35 Xamarin.Android.InstallReferrer.Api.IInstallReferrerStateListener.cs
-rw-r--r--   1  wheel  24503 Jul 23 09:35 Xamarin.Android.InstallReferrer.Api.InstallReferrerClient.cs
-rw-r--r--   1  wheel   6764 Jul 23 09:35 Xamarin.Android.InstallReferrer.Api.ReferrerDetails.cs
-rw-r--r--   1  wheel   3835 Jul 23 09:35 Xamarin.Android.InstallReferrer.BuildConfig.cs
-rw-r--r--   1  wheel   4488 Jul 23 09:35 Xamarin.Android.InstallReferrer.Commons.InstallReferrerCommons.cs
-rw-r--r--   1  wheel  17783 Jul 23 09:35 Xamarin.Google.Android.Finsky.ExternalReferrer.IGetInstallReferrerService.cs
-rw-r--r--   1  wheel   1489 Jul 23 09:35 Xamarin.Google.Android.InstallReferrer.projitems
-rw-r--r--   1  wheel   1840 Jul 23 09:35 __NamespaceMapping__.cs
-rw-r--r--   1  wheel      0 Jul 23 09:35 enumlist
-rw-r--r--   1  wheel  22208 Jul 23 09:34 generator.rsp

Binlog:

samples-dotnet-dotnet-msbuild-BuildAllDotNet.binlog.zip

moljac · 2022-07-23T08:56:56Z

proguard rules do not help:

-dontshrink
-dontoptimize
-dontpreverify

-keep class com.android.installreferrer.api.** { *; }
-keep interface com.android.installreferrer.api.** { *; }

If it's failing on javac, then proguard rules won't help, that is later on.

jonathanpeppers · 2022-07-27T13:31:50Z

azure-pipelines.yml

-  XamarinDotNetWorkloadSource: https://aka.ms/dotnet/maui/rc.3.json
+  XamarinDotNetWorkloadSource: https://aka.ms/dotnet/maui/6.0.400.json


This needs to use the local file below? But can you update .NET & workloads in a separate PR? Just to make sure that doesn't break anything on its own.

workloads.json

moljac added 5 commits May 18, 2022 09:05

installreferrer initial commit

35280f5

spellcheck fix

5217dfe

metadata initial commit

6e6f7fc

template fix

0521c96

namespaces fixes

ac33670

moljac requested a review from jpobst May 19, 2022 07:05

jpobst reviewed May 19, 2022

View reviewed changes

config.json Outdated Show resolved Hide resolved

typo fixed

4bb60d2

jpobst reviewed May 19, 2022

View reviewed changes

source/com.android.installreferrer/installreferrer/Transforms/Metadata.Namespaces.xml Outdated Show resolved Hide resolved

moljac added 2 commits May 19, 2022 17:28

casing fixed according to review

3849b71

verbosity added for troubleshooting

a8a6928

moljac added 8 commits May 25, 2022 23:02

build.cake fixes for correct mapping generation

a67a008

typo fixes

905c79a

Update Xamarin.AndroidX.Migration.props

6e205da

mappings updates

fbe74cf

spell checking updates

50ffa3c

Merge branch 'main' into mu-20220518-installreferrer

96d84eb

Update published-namespaces.txt

8ad8598

namespace verification by default and some love for users

a40688e

jpobst reviewed May 26, 2022

View reviewed changes

moljac added 8 commits May 27, 2022 09:09

Update config.json

c084a58

Update Project.cshtml

388a9c3

Merge branch 'main' into mu-20220518-installreferrer

c54c761

review fixes

11654e3

Merge branch 'mu-20220518-installreferrer' of https://github.com/xama…

575eccf

…rin/AndroidX into mu-20220518-installreferrer

spellchecking fix

8bf0145

installreferrer initial commit

988585f

spellcheck fix

a23327d

moljac added 5 commits July 22, 2022 06:41

Merge branch 'main' into mu-20220518-installreferrer

414b91d

kotlin changes reverted

52fcf67

Update NuGet.config

71834a9

Update azure-pipelines.yml

dfab411

samples cleanup

a9bdcde

Merge branch 'main' into mu-20220518-installreferrer

93ff719

moljac added 4 commits July 26, 2022 12:27

Merge branch 'main' into mu-20220518-installreferrer

eec01a2

samples rewritten

b3beb12

XamarinDotNetWorkloadSource updated

65959d1

Create workloads.json

b5b66b2

jonathanpeppers reviewed Jul 27, 2022

View reviewed changes

This was referenced Jul 27, 2022

Manual updates 20220710 new packages (androidx.enterprise, androidx.window:window-rxjava*...) #582

Merged

Weekly stable updates #589

Merged

moljac added 6 commits July 27, 2022 22:18

Merge branch 'main' into mu-20220518-installreferrer

d8880b3

Merge branch 'main' into mu-20220518-installreferrer

0a16d6a

Merge branch 'main' into mu-20220518-installreferrer

4e3d0c7

Merge branch 'main' into mu-20220518-installreferrer

a6ed0e1

Merge branch 'main' into mu-20220518-installreferrer

56849cf

Update published-namespaces.txt

9c028d7

moljac requested review from jpobst and jonathanpeppers August 15, 2022 05:34

jpobst approved these changes Aug 15, 2022

View reviewed changes

moljac merged commit de330c5 into main Aug 15, 2022

moljac deleted the mu-20220518-installreferrer branch August 15, 2022 14:03

jpobst mentioned this pull request Aug 16, 2022

[update-config.csx] Add ability to "freeze" updates for an artifact. #602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

installreferrer bindings #556

installreferrer bindings #556

moljac commented May 18, 2022 •

edited

Loading

moljac commented May 24, 2022

azure-pipelines bot commented May 24, 2022

jpobst May 26, 2022

jpobst May 26, 2022

moljac May 28, 2022

jpobst May 31, 2022

moljac Jun 16, 2022

jpobst Jun 16, 2022

moljac Jun 27, 2022

jpobst May 26, 2022

moljac May 28, 2022

moljac Jun 16, 2022

jpobst May 26, 2022

moljac May 28, 2022

jpobst May 26, 2022

moljac May 28, 2022

jpobst May 26, 2022

jpobst May 26, 2022

moljac May 28, 2022

moljac commented Jul 22, 2022

moljac commented Jul 22, 2022

azure-pipelines bot commented Jul 22, 2022

moljac commented Jul 23, 2022 •

edited

Loading

moljac commented Jul 23, 2022 •

edited

Loading

jonathanpeppers Jul 27, 2022

		@@ -0,0 +1,15 @@
		Xamarin is not responsible for, nor does it grant any licenses to, third-party packages. Some packages may require or install dependencies which are governed by additional licenses.

		Note: This component depends on [com.android.installreferrer:installrefererrer](https://maven.google.com/web/index.html?q=installreferrer#com.android.installreferrer:installreferrer), which is subject to the [Apache 2.0](https://developer.android.com/google/play/installreferrer/)

		XamarinDotNetWorkloadSource: https://aka.ms/dotnet/maui/rc.3.json
		XamarinDotNetWorkloadSource: https://aka.ms/dotnet/maui/6.0.400.json

installreferrer bindings #556

installreferrer bindings #556

Conversation

moljac commented May 18, 2022 • edited Loading

Does this change any of the generated binding API's?

Describe your contribution

moljac commented May 24, 2022

azure-pipelines bot commented May 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moljac commented Jul 22, 2022

moljac commented Jul 22, 2022

azure-pipelines bot commented Jul 22, 2022

moljac commented Jul 23, 2022 • edited Loading

moljac commented Jul 23, 2022 • edited Loading

Choose a reason for hiding this comment

moljac commented May 18, 2022 •

edited

Loading

moljac commented Jul 23, 2022 •

edited

Loading

moljac commented Jul 23, 2022 •

edited

Loading