This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Move second batch of GPS package-specific templates to AndroidX default template. #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
gps-phase-2
branch
4 times, most recently
from
cd86ca5 to
517a64f
Compare
moljac
approved these changes
Sep 5, 2024
jpobst
added a commit
to dotnet/android-libraries
that referenced
this pull request
Sep 5, 2024
…ult template. (#950) Move the packages in GPS that use the following package-specific templates to this repository and switch them to using the default template: - brotli - chromium-cronet - codehaus-mojo - datatransport - flatbuffers - grpc - opencensus - perfmark - protobuf-lite - squareup-okhttp - squareup-okhttp3 - squareup-picasso - squareup-retrofit - squareup-retrofit2 - squareup-okio - squareup-javapoet - tensorflow-lite - user-messaging-platform - zxing One wrinkle is that AndroidX does not allow a stable package to depend on a prerelease package: ```xml <!-- Warnings we want to error on: --> <!-- NU5104: A stable release of a package should not have a prerelease dependency. --> <WarningsAsErrors>$(WarningsAsErrors);NU5104</WarningsAsErrors> ``` Although we should always abide by this rule, we are bound by Google's packaging decisions and sometimes we have no choice. The `Xamarin.TensorFlow.Lite.Support.Api` and `Xamarin.TensorFlow.Lite.Task.Vision.PlayServices.Library` packages we are moving from GPS have a prerelease dependency. (GPS repository does not enforce this rule.) In order to keep this rule globally, but allow packages to opt out of it, add the `allowPrereleaseDependencies` artifact-level field to `config.json`: ```json { "groupId": "org.tensorflow", "artifactId": "tensorflow-lite-task-vision-play-services", "version": "0.4.4", "nugetVersion": "0.4.4.6", "nugetId": "Xamarin.TensorFlow.Lite.Task.Vision.PlayServices.Library", "allowPrereleaseDependencies": true, "comments": "Depends on Xamarin.Google.Android.ODML.Image which only has a prerelease version.", ... } ``` Companion PR that removes these packages from GPS: xamarin/GooglePlayServicesComponents#906
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the packages that use the following package-specific templates from this repository as they have moved to AndroidX repository:
Companion PR that adds them to AndroidX: dotnet/android-libraries#950