This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Bug] CollectionView Header cause delay to adding items. #7102
Labels
Comments
Confirmed this is happening. The other thing that I'm noticing is that the second a is added to the top. And from there all the b's are also added before the initial a. The problem goes away when you take out the header. Not tested with iOS yet since the implementation was just done today. |
jfversluis
added
a/collectionview
p/Android
and removed
s/unverified
New report that has yet to be verified
labels
Aug 8, 2019
I changed the repro so it does numbers instead, so the problem is clearer. |
Great, thank you! In addition when I enable the selection mode and select an item, this also crashes because of the indices not being lined up correctly. Probably because of the header offset not taken into account. /cc: @hartez |
hartez
added a commit
that referenced
this issue
Aug 11, 2019
hartez
added a commit
that referenced
this issue
Aug 17, 2019
6 tasks
samhouts
pushed a commit
that referenced
this issue
Aug 28, 2019
* Move all the header/footer adjustment to IItemsViewSource fixes #7121 fixes #7102 partially implements #3172 fixes #7243 * Fix selection bugs introduced by header/footer on Android * Implement grouping for CollectionView on Android * Enable grouping tests for Android * Naming and comment cleanup * Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com> * Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this issue
Oct 16, 2019
* Move all the header/footer adjustment to IItemsViewSource fixes xamarin#7121 fixes xamarin#7102 partially implements xamarin#3172 fixes xamarin#7243 * Fix selection bugs introduced by header/footer on Android * Implement grouping for CollectionView on Android * Enable grouping tests for Android * Naming and comment cleanup * Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com> * Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this issue
Oct 16, 2019
* Move all the header/footer adjustment to IItemsViewSource fixes xamarin#7121 fixes xamarin#7102 partially implements xamarin#3172 fixes xamarin#7243 * Fix selection bugs introduced by header/footer on Android * Implement grouping for CollectionView on Android * Enable grouping tests for Android * Naming and comment cleanup * Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com> * Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Adding a header to a collectionview in the latest prerelease causes items to be delayed.
Steps to Reproduce
Expected Behavior
In the repro if you click the add button it adds an "a" to the collectionview via an Observablecollection in a viewmodel. If i click it again I expect a "b".
Actual Behavior
I get an "a" the second time and a "b" the third time, as if delayed by one.
Basic Information
Reproduction Link
CollectionHeaderTest.zip
The text was updated successfully, but these errors were encountered: