This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Internal] Fix default items #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some issues in the MSBuild evaluation order that caused the default items files to never get used.
|
@mhutch, |
samhouts
pushed a commit
that referenced
this pull request
Sep 15, 2017
There were some issues in the MSBuild evaluation order that caused the default items files to never get used.
jassmith
pushed a commit
that referenced
this pull request
Oct 26, 2017
* [Android] Fix bugzilla58868 (#1106) * [Android] Only set elevation in Lolipop or newer * Update submodule * [Android] Restore and obsolete EditorEditText and EntryEditText controls (#1114) * Restore and obsolete EditorEditText and EntryEditText controls * Don't need to use the obsolete classes in the renderers * Update obsolete messages * [Internal] Fix loading props file on older MSBuild versions (#1112) * Fix loading props file on older MSBuild versions * Fix applying metadata to default items * Fix build error caused be errant ' * Fix ' issue better this time * One more missing ' * Fix NRE when removing multiple pages in NavigationPageRenderer (#1108) * Update 53179 test to remove 2 pages; fix for NRE when removing two pages with Android Support 25+ * Add missing step to UI test * [UWP] ListView ItemSelected event will fire only once on selection changed (#1005) * Add repro for 44886 * [UWP] Fire ListItemClicked when Selection changes This will automatically set the value on the renderer and prevent the double event from firing. * Clean up repro * Update test case for delection scenario * [Core] Allow ListView item deselection * [UWP] Send events when item is deselected, too * Test works better when you DO something. * [Android] Fix NRE when page is being disposed (#1118) * [ControlGallery] Add test case for bugzilla 59097 * [Android] Fix NRE * [iOS] Make sure to include query path on generated url (#1119) * Fix default items (#1123) There were some issues in the MSBuild evaluation order that caused the default items files to never get used. * Revert PR #762 (#1134) * [UITests] Update packages, fix failing test (#1140) * [Nuget] Update UITest packages * [UITest] Fix failing tests by scrolling to results first * [PagesGallery] Remove iOS7 storyboard * Revert "[UITest] Fix failing tests by scrolling to results first" This reverts commit 54eba70. * [Controls] Move results labels on 51773 to the top * [iOS] launch image for iPhoneX * [Build] Move to XCode 9 support * Fix failing UI tests for Android FormsApplicationActivity (#1141) * Fix broken test for 57910 when using FormsApplicationActivity * Fix NRE when removing a page during OnAppearing using FormsApplicationActivity * Update 45926 test to work correctly with FormsApplicationActivity * Update 32830 test so it doesn't crash on FormsApplicationActivity * Longer wait before refreshing appearing messages (to work with FormsApplicationActivity) * Fix input transparency issue with old FrameRenderer * Remove extraneous using directive * Just ignore test 32830 on FormsApplicationActivity * [Controls] Add missing directive * Update submodule * [UWP] Use ItemClick to re-enable use of enter key for selection on ListView (#1133) * [Android] Restore pinch gestures and fix listview item selection (#1135) * Repro * Fail test if tap command is executed more than once. * Update error message * Handle context actions and taps without breaking selection * Fix 58833 test * Prevent InnerGestureListener from swallowing clicks and preventing selection * Repro for 57515 * Add gestures category to appropriate tests * Test notes * Restore the tap gesture handling * Better test name * Simplify InnerGestureListener constructor; handle OnDown only if listening * OnInterceptTouchEvent for IsEnabled handling * Fix incorrect class filter in TapGestureHandler * Restore MotionEventHelper * Add IsEnabled check on OnTouchEvent * Reinstate pinch gestures * Checkpoint (trying to figure out how to handle button elevation) * Rip out elevation ordering in DefaultRenderer * Working version of pinch-to-zoom test * Clean up lazy initializers, remove unnecessary members * One fewer Java.Lang.Object * Fix issue number; clean up notes and issue number changes * Remove conditional * Restore correct issue number * Automate all the options for 58833 test * Remove unnecessary automation ID * Formatting cleanup; reinstate gesture detector dispose checks * Updating Xamarin UI test version to avoid iOS crashes; update test to open iOS context actions * Attempting to get 58833 test running on all iOS versions * [Android] Hide actionbar when MDP with NavigationPage with hidden NavigationBar (#1120) * [ControlGallery] Add repo and test for Bugzilla27731 * [Android] Hide ActionBar if MDP with NavigationPage that hides the NavigationBar * [iOS] Can activate ContextActions on ListViews reliably again (#1144) * Add ContextActions test category * Add repro for 58875 * [iOS] Null check for the Delegate; clear the static WeakRef on dispose * Add iOS prototypical cell cache for LV RowHeight calcs (#1143) * Fix UI test for 58875 on Android * [Nuget]Fix condition to import DefaultItems.targes (#1146) * Use bitwise ops on caching strategy in ListViewAdapter.cs (#1149) * Revert "[UWP] Use ItemClick to re-enable use of enter key for selection on ListView (#1133)" This reverts commit d1bf93b. * Revert "[Nuget]Fix condition to import DefaultItems.targes (#1146)" This reverts commit 0092456. * Fix nuspec file to install DefaultItems.targets in PCL projects (#1163) * [Android]Ignore warning * Add ProjectCapability to targets file (#1164) * Prevent Flags/IsInitialized check from crashing Android app on restart (#1151) * Prevent Android app crashes on configuration restarts when flags are set * Update UI test * Fix typos * Don't prevent FastRenderers flag from being set * Revert PR #882 (#1190) * Revert "Fix border on android buttons (#941)" (#1192) This reverts commit 20d33c6. * [Build] Update submodule * Checking IsDestroyed before using FragmentManager in Dispose() (#1194) * [UITest] Fix uitest for elevation * [UITest] Add preserve (#1105) * [Android] Handle rapid taps when only single-tap recognizer is present (#1188) * Handle rapid tapping correctly * Remove failed optimization attempt for 2-pointer gestures * [UWP] Fix for UWP crashing on load when compiled with .NET Native for the store. (#1186) * [Xaml] Chain op_implicit for OnPlatform (if needed) (#1176) * [Xaml] Chain op_implicit for OnPlatform (if needed) For OnPlatform<T>, if a conversion for T to the destination type exists, first convert OnPlatform<T> to T, the T to the dest type Also unify the way we look for op_implicit operators * [Xaml] only apply the double opImplicit if a flag is set * [C] allow conversion on parameter * Clear MainPage renderer if exists after reload (#1200) * [UWP] Inherit from Panel on WrapperControl (#1204) * [UWP] Inherit from Panel on WrapperControl * Fix typo * [Controls] Fix cherry-pick * fix-cp * [*] Expose the Flags to the Core (#1181) * [*] Expose the Flags to the Core * docs * [C] Hide Device.Flags * Allow duplicate issue numbers per tracker (#1127) * fix-cp * Do not attempt to clear data on app start (crashes on iOS 11) * [Packages] Update UITest and consolidate packages (#1201) * [Packages] Update UITest and consolidate packages * [Controls] Remove old packages * [UITest] Try fix UITests iOS11 * [UITests] Use back instead of custom class * [Android] Prevent ObjectDisposedExceptions in ListViews with Header/FooterTemplates (#1155) * Update repro to include header/footers with bound props * [Android] Clear renderers of ListView header/footers And don't call `RemoveAllViews`, because that causes the ObjectDisposedExceptions. * Undo changes meant for 2.5.0 * [UITest] Fix build * Stop forcing FormsTextBox content to ForegroundFocusBrush on UWP (#1206) * Proper revert of PR #882 (#1220) * [Android] Use non-deprecated constructor for GestureDetector (#1227) * Use non-deprecated constructor for GestureDetector * Only grab Context once * Only get Context once
|
Hi @mhutch, just found that even on non-SDK style projects, the So this might need to be changed to check for some other property, possibly |
samhouts
added
the
t/housekeeping ♻︎
PureWeen
pushed a commit
that referenced
this pull request
Oct 24, 2019
There were some issues in the MSBuild evaluation order that caused the default items files to never get used.
PureWeen
pushed a commit
that referenced
this pull request
Oct 24, 2019
There were some issues in the MSBuild evaluation order that caused the default items files to never get used.
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace * Fixes #1129 - set empty required declarations on UWP (#1133) * Fixes #1129 - set empty required declarations on UWP * Update Permissions.uwp.cs * Update Xamarin.Essentials.csproj (#1136) * GH-1142 AccessBackgroundLocation only when compile & running Q (#1143) * AccessBackgroundLocation only when compile & running Q * put if compile check around permission * GH-1121 If VC is null use TraitCollection (#1144) * Fixes #1123 (#1126) * Update PlacemarkExtensions.xml (#1132) Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Michael <Michael@ZPF.fr>
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Implement vertical accuracy in GeoLocation API (#1103) * Location: add property 'VerticalAccuracy' (#1099) * vertical accuracy is only available in Android API level 26 and above (#1099) * update Samples app to show vertical accuracy on GeolocationPage * add missing documentation bits for Location.VerticalAccuracy * .gitattributes: get better diff context for C# code (#1115) * Location.VerticalAccuracy: add runtime check for Android version (#1099) (#1116) * the compile-time check is not enough * it crashed on old Android versions (<8.0) * GH-1102 Fix launcher on older devices (#1120) * Update Launcher.ios.tvos.cs * OpenUrlAsync was introduced in iOS 10 not 12 https://docs.microsoft.com/en-us/dotnet/api/uikit.uiapplication.openurlasync?view=xamarin-ios-sdk-12 * Fix trailing whitespace * Really? fix whitespace * Really! Fix whitespace * Fixes #1129 - set empty required declarations on UWP (#1133) * Fixes #1129 - set empty required declarations on UWP * Update Permissions.uwp.cs * Update Xamarin.Essentials.csproj (#1136) * GH-1142 AccessBackgroundLocation only when compile & running Q (#1143) * AccessBackgroundLocation only when compile & running Q * put if compile check around permission * GH-1121 If VC is null use TraitCollection (#1144) * Fixes #1123 (#1126) * Update PlacemarkExtensions.xml (#1132) Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: James Montemagno <james.montemagno@gmail.com> Co-authored-by: Michael <Michael@ZPF.fr> Co-authored-by: Jonathan Dick <jodick@microsoft.com> Co-authored-by: Janus Weil <janus@gcc.gnu.org> Co-authored-by: Michael <Michael@ZPF.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes issues in MSBuild evaluation order that caused the default items files to never get used.
Bugs Fixed
N/A
API Changes
N/A
Behavioral Changes
N/A
PR Checklist