Remove string allocations (dotnet#9718)

xamarin · Feb 22, 2021 · 4f20486 · 4f20486
1 parent 6b691f5
commit 4f20486
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/LanguageService/Symbols.fs b/LanguageService/Symbols.fs
@@ -83,7 +83,7 @@ type FSharpMemberOrFunctionOrValue with
     member x.IsOperatorOrActivePattern =
         let name = x.DisplayName
         if name.StartsWith "( " && name.EndsWith " )" && name.Length > 4
-        then name.Substring (2, name.Length - 4) |> String.forall (fun c -> c <> ' ')
+        then name.IndexOf(' ', 2, name.Length - 4) = -1
         else false
 
 

diff --git a/LanguageService/Tokenizer.fs b/LanguageService/Tokenizer.fs
@@ -785,7 +785,7 @@ module internal Tokenizer =
         let text = sourceText.GetSubText(span).ToString()
         // backticked ident
         if text.EndsWith "``" then
-            match text.[..text.Length - 3].LastIndexOf "``" with
+            match text.LastIndexOf("``", text.Length - 3, text.Length - 2) with
             | -1 | 0 -> span
             | index -> TextSpan(span.Start + index, text.Length - index)
         else 
@@ -798,9 +798,9 @@ module internal Tokenizer =
 
         let isDoubleBacktickIdent (s: string) =
             let doubledDelimiter = 2 * doubleBackTickDelimiter.Length
-            if s.StartsWith(doubleBackTickDelimiter) && s.EndsWith(doubleBackTickDelimiter) && s.Length > doubledDelimiter then
-                let inner = s.Substring(doubleBackTickDelimiter.Length, s.Length - doubledDelimiter)
-                not (inner.Contains(doubleBackTickDelimiter))
+            if s.Length > doubledDelimiter && s.StartsWith(doubleBackTickDelimiter, StringComparison.Ordinal) && s.EndsWith(doubleBackTickDelimiter, StringComparison.Ordinal) then
+                let inner = s.AsSpan(doubleBackTickDelimiter.Length, s.Length - doubledDelimiter)
+                not (inner.Contains(doubleBackTickDelimiter.AsSpan(), StringComparison.Ordinal))
             else false
 
         let isIdentifier (ident: string) =