Skip to content
This repository has been archived by the owner on Mar 8, 2021. It is now read-only.

Fix mono-api-html invocation; add missing --ignore-change-parameter-n… #2

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Fix mono-api-html invocation; add missing --ignore-change-parameter-n… #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ check: check-inter-api-level
$(call BUILD_API_INFO,temp,$(XA_FRAMEWORK_DIR))
failed=0 ; \
for file in $(CORE_ASSEMBLIES) $(TFV_ASSEMBLIES) ; do \
if $(MONO_API_HTML) $(REFERENCE_DIR)/$$file.xml temp/$$file.xml | grep '>Removed' > /dev/null 2>&1 ; then \
if $(MONO_API_HTML) $(REFERENCE_DIR)/$$file.xml temp/$$file.xml --ignore-changes-parameter-names | grep '>Removed' > /dev/null 2>&1 ; then \
echo "ABI BREAK IN: $$file.dll" ; \
$(MONO_API_HTML) $(REFERENCE_DIR)/$$file.xml temp/$$file.xml ; \
$(MONO_API_HTML) $(REFERENCE_DIR)/$$file.xml temp/$$file.xml --ignore-changes-parameter-names; \
failed=1; \
fi ; \
done ; \
Expand Down Expand Up @@ -128,7 +128,7 @@ check-inter-api-level: -create-inter-api-infos
echo "# reading extras from: $$extras_in"; \
extra=`cat $$extras_in 2>/dev/null`; \
out=`mktemp interdiff-XXXXXX.html` ; \
command="$(MONO_API_HTML) "$$prev" "$$cur" --ignore-changes-parameter-names --ignore-changes-virtual --ignore-changes-property-setters $$extra"; \
command="$(MONO_API_HTML) \"$$prev\" \"$$cur\" --ignore-changes-parameter-names --ignore-changes-virtual --ignore-changes-property-setters $$extra"; \
echo $$command; \
eval $$command > "$$out" 2>&1; \
if grep '>Removed' $$out > /dev/null 2>&1 ; then \
Expand Down