This repository has been archived by the owner on Mar 8, 2021. It is now read-only.
Fix member removal check #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#771 (comment) Checking for `>Removed` is insufficient for checking for API compatibility breakage, as sometimes `mono-api-html` will emit `>Modified`. For example, [xamarin-android PR #771][xa771] changes the type of the `Android.App.NotificationChannel.LockscreenVisibility` property from `int` to `NotificationVisibility`. This was expected to result in a build failure, due to API breakage. [xa771]: dotnet/android#771 (comment) It didn't. Update the member removal check to instead check for the existence of the `data-is-breaking` tag. This will hopefully improve compatibility checks in the future.
|
Is |
|
I just read the mono-api-html sources and I think it can be regarded as identifying ABI breakage. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#771 (comment)
Checking for
>Removedis insufficient for checking for APIcompatibility breakage, as sometimes
mono-api-htmlwill emit>Modified.For example, xamarin-android PR #771 changes the type of the
Android.App.NotificationChannel.LockscreenVisibilityproperty frominttoNotificationVisibility. This was expected to result in abuild failure, due to API breakage.
It didn't.
Update the member removal check to instead check for the existence of
the
data-is-breakingtag. This will hopefully improve compatibilitychecks in the future.