-
Notifications
You must be signed in to change notification settings - Fork 514
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix NLLanguageRecognizer crash (#6689)
The dispose of `nslang` was happening outside of the check if `nslang` is null. This was causing a crash when trying to recognise a string that contains just one number. Fixes: #6688
- Loading branch information
1 parent
b517f70
commit 42311ca
Showing
2 changed files
with
13 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42311ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥
Test results
113 tests failed, 0 tests passed.
Failed tests
42311ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Build was (probably) aborted
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥
✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.286.pkg xamarin.mac-5.15.0.286.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥
Test results
3 tests failed, 168 tests passed.
Failed tests
42311ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Device tests completed (Canceled) on TvOS on Azure DevOps(TvOS): Html Report 🔥
Test results
# Test run in progress: Building: 1, Running: 1, RunQueued: 90, Succeeded: 14, Ignored: 946, TimedOut: 7
Failed tests