[xharness] Improve code to not throw exceptions in the first place in…

…stead of catching and ignoring. (#9118)
xamarin · Oct 21, 2020 · 4f54eec · 4f54eec
1 parent 0030b9f
commit 4f54eec
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Utilities/ProjectFileExtensions.cs b/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Utilities/ProjectFileExtensions.cs
@@ -236,11 +236,7 @@ public static void SetTopLevelPropertyGroupValue (this XmlDocument csproj, strin
 
 		public static void RemoveTargetFrameworkIdentifier (this XmlDocument csproj)
 		{
-			try {
-				RemoveNode (csproj, "TargetFrameworkIdentifier");
-			} catch {
-				// ignore exceptions, if not present, we are not worried
-			}
+			RemoveNode (csproj, "TargetFrameworkIdentifier", throwOnInexistentNode: false);
 		}
 
 		public static void SetAssemblyName (this XmlDocument csproj, string value)