Skip to content

Commit

Permalink
[msbuild] Fix arguments to error logging for GetMinimumOSVersionTask. (
Browse files Browse the repository at this point in the history
…#9248)

The filename arguments to the error logging must be strings, otherwise the
wrong logging overload is picked, and the resulting error message makes no
sense.
  • Loading branch information
rolfbjarne authored Jul 31, 2020
1 parent d9295b1 commit 58e10cb
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public override bool Execute ()
try {
plist = PDictionary.FromFile (AppManifest.ItemSpec);
} catch (Exception ex) {
Log.LogError (null, null, null, AppManifest, 0, 0, 0, 0, MSBStrings.E0010, AppManifest, ex.Message);
Log.LogError (null, null, null, AppManifest.ItemSpec, 0, 0, 0, 0, MSBStrings.E0010, AppManifest.ItemSpec, ex.Message);
return false;
}
}
Expand All @@ -31,7 +31,7 @@ public override bool Execute ()
if (string.IsNullOrEmpty (minimumOSVersionInManifest)) {
MinimumOSVersion = SdkVersion;
} else if (!IAppleSdkVersion_Extensions.TryParse (minimumOSVersionInManifest, out var _)) {
Log.LogError (null, null, null, AppManifest, 0, 0, 0, 0, MSBStrings.E0011, minimumOSVersionInManifest);
Log.LogError (null, null, null, AppManifest.ItemSpec, 0, 0, 0, 0, MSBStrings.E0011, minimumOSVersionInManifest);
return false;
} else {
MinimumOSVersion = minimumOSVersionInManifest;
Expand Down

5 comments on commit 58e10cb

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Pipeline scripts tests failed on VSTS: device tests iOS (DDFun) 🔥

The tests of the scripts used in the pepeline failed. The build was cancelled.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed installing dependencies.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests iOS (Cambridge) ❌

Device tests failed on VSTS: device tests iOS (Cambridge).

Test results

150 tests' device not found, 0 tests passed.

Pipeline on Agent XI-W-CHARMANDER

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

Provisioning succeeded
Build succeeded
✅ Packages built successfully

View packages

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 183 tests passed.

Failed tests

  • Generator tests/.NET: HarnessException (Harness exception for 'Generator tests': System.IO.FileNotFoundException: Could not find file "/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/jenkins-results/tests/bgen-tests/355/build-iOS-20200731_153601.txt"
    File name: '/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/jenkins-results/tests/bgen-tests/355/build-iOS-20200731_153601.txt'
    at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) [0x00259] in /Users/builder/jenkins/workspace/build-package-osx-mono/2020-02/external/bockbuild/builds/mono-x64/mcs/class/corlib/System.IO/FileStream.cs:274
    at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share) [0x00000] in /Users/builder/jenkins/workspace/build-package-osx-mono/2020-02/external/bockbuild/builds/mono-x64/mcs/class/corlib/System.IO/FileStream.cs:91
    at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare)
    at Microsoft.DotNet.XHarness.iOS.Shared.Logging.LogFile.GetReader () [0x00001] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Logging/LogFile.cs:58
    at Xharness.TestTasks.RunTest.BuildAsync () [0x00240] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/xharness/TestTasks/RunTest.cs:71
    at Xharness.TestTasks.RunTest.ExecuteAsync () [0x000d8] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/xharness/TestTasks/RunTest.cs:97
    at Microsoft.DotNet.XHarness.iOS.Shared.Tasks.TestTasks.RunInternalAsync () [0x00226] in /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/TestTask.cs:283 )

Please sign in to comment.