Skip to content

Commit

Permalink
[AppKit] Fix issue 4837 by moving the category to be inline. Fixes #4837
Browse files Browse the repository at this point in the history 
 (#4875)

* [AppKit] Fix issue 4837 by moving the category to be inline. Fixes #4837

The NSControlEditingSupport needs to be inline to make the use of the
API simpler allowing users to inherit an override the method.

Fixes #4837
  • Loading branch information
@mandel-macaque
mandel-macaque authored Oct 10, 2018
1 parent 8088193 commit a75c0b9
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions src/appkit.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22678,11 +22678,13 @@ partial interface NSPrintOperation {
NSPrintRenderingQuality PreferredRenderingQuality { get; }
}

#if !XAMCORE_4_0
[Category, BaseType (typeof (NSResponder))]
partial interface NSControlEditingSupport {
[Mac (10, 7), Export ("validateProposedFirstResponder:forEvent:")]
bool ValidateProposedFirstResponder (NSResponder responder, [NullAllowed] NSEvent forEvent);
}
partial interface NSControlEditingSupport {
[Mac (10, 7), Export ("validateProposedFirstResponder:forEvent:")]
bool ValidateProposedFirstResponder (NSResponder responder, [NullAllowed] NSEvent forEvent);
}
#endif

partial interface NSResponder {
[Mac (10, 7), Export ("wantsScrollEventsForSwipeTrackingOnAxis:")]
Expand All @@ -22696,6 +22698,10 @@ partial interface NSResponder {

[Mac (10, 8), Export ("quickLookWithEvent:")]
void QuickLook (NSEvent withEvent);

// From NSControlEditingSupport category. Needs to be here to make the API easier to be used. issue 4837
[Mac (10, 7), Export ("validateProposedFirstResponder:forEvent:")]
bool ValidateProposedFirstResponder (NSResponder responder, [NullAllowed] NSEvent forEvent);
}

[Category, BaseType (typeof (NSResponder))]
Expand Down

3 comments on commit a75c0b9

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : hudson.AbortException: script returned exit code 2

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

20 tests failed, 0 tests skipped, 205 tests passed.

Failed tests

  • System/Mac/Modern: Failed (Test run failed.)
  • System.ServiceModel.Web/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.63 MB left of 1024 MB required)
  • Mono.Data.Sqlite/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.63 MB left of 1024 MB required)
  • Mono.Data.Tds/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.62 MB left of 1024 MB required)
  • System.IO.Compression/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.62 MB left of 1024 MB required)
  • System.IO.Compression.FileSystem/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.61 MB left of 1024 MB required)
  • Mono.CSharp/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.61 MB left of 1024 MB required)
  • System.Security/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.61 MB left of 1024 MB required)
  • System.ServiceModel/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.6 MB left of 1024 MB required)
  • System.IdentityModel/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.6 MB left of 1024 MB required)
  • introspection/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.59 MB left of 1024 MB required)
  • dont link/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.59 MB left of 1024 MB required)
  • dont link/iOS Unified 32-bits - simulator/Release: Failed (Not enough space on the root drive '/': 906.59 MB left of 1024 MB required)
  • link all/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.58 MB left of 1024 MB required)
  • link all/iOS Unified 32-bits - simulator/Release: Failed (Not enough space on the root drive '/': 906.58 MB left of 1024 MB required)
  • link sdk/iOS Unified 32-bits - simulator/Debug: Failed (Not enough space on the root drive '/': 906.57 MB left of 1024 MB required)
  • link sdk/iOS Unified 32-bits - simulator/Release: Failed (Not enough space on the root drive '/': 906.57 MB left of 1024 MB required)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): Failed (Not enough space on the root drive '/': 906.57 MB left of 1024 MB required)
  • monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): Failed (Not enough space on the root drive '/': 906.56 MB left of 1024 MB required)
  • monotouch-test/iOS Unified 32-bits - simulator/Debug (all optimizations): Failed (Not enough space on the root drive '/': 906.56 MB left of 1024 MB required)

@chamons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure: Not enough space on the root drive '/': 906.59 MB left of 1024 MB required

@chamons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting state to success where context is continuous-integration/jenkins/branch.

No blocking issues found

Please sign in to comment.