-
Notifications
You must be signed in to change notification settings - Fork 517
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[macos] Fix Constants.mac.cs.in for backward compatibility (#5181)
On macOS the path changes are forward but not backward compatible. This means we need to keep older values, as they will work on newer OS, while the new path won't work (on older OS). The test are updated to add exceptions for such cases - in order to give us a better chance to spot typos (since they were some). This should fix xamarin/maccore#1174 xamarin/maccore#1175 xamarin/maccore#1176 xamarin/maccore#1177
- Loading branch information
1 parent
eb8b4f0
commit acf8357
Showing
2 changed files
with
13 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acf8357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥
✅ Build succeeded
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ API Diff (from stable)
✅ Generator Diff (no change)
🔥 Test run failed 🔥
Test results
1 tests failed, 0 tests skipped, 283 tests passed.
Failed tests
acf8357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are unrelated.
Xamarin.Mac.dll
Namespace ObjCRuntime
Type Changed: ObjCRuntime.Constants
Modified fields:
acf8357
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting state to
success
where context iscontinuous-integration/jenkins/branch
.No blocking issues found