Hide advanced NSObject members to follow Xamarin.Android

[rolfbjarne]

Suggestion:

Hide members from NSObject that customers shouldn't use.

Candidates:

• Handle:

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 461 in 337f3ef

  public IntPtr Handle {

• SuperHandle:

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 446 in 337f3ef

  public IntPtr SuperHandle {

• IntPtr constructor (never seen this constructor used):

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 134 in 337f3ef

  public NSObject (IntPtr handle) : this (handle, false) {

• IntPtr, bool constructor (never seen this constructor get used):

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 137 in 337f3ef

  public NSObject (IntPtr handle, bool alloced) {

• Alloc (never seen this method used):

  xamarin-macios/src/Foundation/NSObject.iOS.cs

  Line 31 in 337f3ef

  public static NSObject Alloc (Class kls) {

• Init (never seen this method used):

  xamarin-macios/src/Foundation/NSObject.iOS.cs

  Line 36 in 337f3ef

  public void Init () {

• IsDirectBinding (required by binding code, but afaik never called directly by customers):

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 96 in 337f3ef

  protected internal bool IsDirectBinding {

• IsNewRefCountEnabled (should never need to be called by customers since does nothing but return a constant value):

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 166 in 337f3ef

  public static bool IsNewRefcountEnabled ()

• MarkDirty (required by binding code afaik, but shouldn't have to be called by customers):

  xamarin-macios/src/Foundation/NSObject2.cs

  Line 177 in 337f3ef

  protected void MarkDirty () {

Ref:

• [Mono.Android] Hide "internal" members of JLO from IDEs. dotnet/android#4583
• https://xamarinhq.slack.com/archives/C03CCJNR7/p1587407994218100

[spouliot]

Semi random thoughts...

I do not see an issue hiding the properties ([Super]Handle) from intellisense but IMO they should remain visible in the debugger.

The only times I recall seeing NSObject constructors are related to manual binding code for

• adding a NSObject-based pointer to a weak/native managed collection (processed by native code);
• create an instance of an unknown type to get its description

TBH we forgot to make them protected in XAMCORE_2_0 like the generated bindings for the subclasses. So the same solution is that use Runtime.GetNSObject<NSObject> (ptr) if it's really needed (not that we're talking about removing them).

[dalexsoto]

By Hide you mean adding EditorBrowsable with Advanced or Never right? If so 👍 but I have to agree with @spouliot that [Super]Handle should still be visible under the debugger.