[runtime] Support binding NSObjects as IntPtr. Fixes #41132. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support binding NSObjects as IntPtr. This is usually not a problem, because when we fetch the ObjC signature for a method, we usually get the signature as exported by us, (in which case a parameter bound as 'IntPtr' would be treated as 'void *' in the dynamic registrar) *except* when the selector corresponds with a protocol the type implements, in which case we get the signature as defined in the protocol. https://bugzilla.xamarin.com/show_bug.cgi?id=41132
|
Build success |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 22, 2021
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@a246ede [TouchRunner] Avoid a NRE when unable to configure the selected transport mechanism. (xamarin#106) * xamarin/Touch.Unit@2f0fad5 [TouchRunner] Add some tracing (xamarin#105) * xamarin/Touch.Unit@2ef1771 [TouchRunner] Use CFString.FromHandle instead of NSString.FromHandle. (xamarin#104) * xamarin/Touch.Unit@bd62d53 [Touch.Client] There's no need to include Xamarin.iOS in Mac Catalyst projects. (xamarin#103) Diff: https://github.com/spouliot/Touch.Unit/compare/07067b6a1c72e62163c0e8c95fc6c5762626f65c..a246ede5fb7ca0eda93f58320a5233de5076a973
Merged
rolfbjarne
added a commit
that referenced
this pull request
Jul 23, 2021
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@a246ede [TouchRunner] Avoid a NRE when unable to configure the selected transport mechanism. (#106) * xamarin/Touch.Unit@2f0fad5 [TouchRunner] Add some tracing (#105) * xamarin/Touch.Unit@2ef1771 [TouchRunner] Use CFString.FromHandle instead of NSString.FromHandle. (#104) * xamarin/Touch.Unit@bd62d53 [Touch.Client] There's no need to include Xamarin.iOS in Mac Catalyst projects. (#103) Diff: https://github.com/spouliot/Touch.Unit/compare/07067b6a1c72e62163c0e8c95fc6c5762626f65c..a246ede5fb7ca0eda93f58320a5233de5076a973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support binding NSObjects as IntPtr. This is usually not
a problem, because when we fetch the ObjC signature for a
method, we usually get the signature as exported by us,
(in which case a parameter bound as 'IntPtr' would be treated
as 'void ' in the dynamic registrar) *except when the
selector corresponds with a protocol the type implements,
in which case we get the signature as defined in the protocol.
https://bugzilla.xamarin.com/show_bug.cgi?id=41132