[msbuild] Use the macOS SDK to build Mac Catalyst apps instead of the iOS SDK #10644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commits in xamarin/Xamarin.MacDev: * xamarin/Xamarin.MacDev@1e738e9 [Xamarin.MacDev] Extract the code to convert between Mac Catalyst versions to a separate file. (xamarin#89) * xamarin/Xamarin.MacDev@a3bb12c [Xamarin.MacDev] Add methods to map between iOS and macOS versions for Mac Catalyst. (xamarin#88) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/02d6d05be3506c89a3b4fa8a8ceb7f33712a8f46..1e738e9f7f80e76e1f48690d1f95a7457ddead74
… iOS SDK From a native compilation perspective, compilating a Mac Catalyst is the macOS SDK + a dash of iOS, so use the native macOS SDK to compile, and then do the corresponding adjustments elsewhere. At the same time document which version we want for the sdk version and the deployment target in mtouch, and adjust the code accordingly (sdk version: macOS version; deployment target: iOS version).
spouliot
approved these changes
Feb 15, 2021
dalexsoto
approved these changes
Feb 15, 2021
❌ Tests failed on Build ❌Tests failed on Build. Test results7 tests failed, 174 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097' |
❌ Tests failed on Build ❌Tests failed on Build. Test results3 tests failed, 178 tests passed.Failed tests
Pipeline on Agent XAMBOT-1095 |
|
Test failures are unrelated:
|
tj-devel709
approved these changes
Feb 16, 2021
mandel-macaque
approved these changes
Feb 16, 2021
emaf
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a native compilation perspective, compilating a Mac Catalyst is the macOS
SDK + a dash of iOS, so use the native macOS SDK to compile, and then do the
corresponding adjustments elsewhere.
At the same time document which version we want for the sdk version and the
deployment target in mtouch, and adjust the code accordingly (sdk version:
macOS version; deployment target: iOS version).
This also requires bumping Xamarin.MacDev.
New commits in xamarin/Xamarin.MacDev:
between Mac Catalyst versions to a separate file. ([registrar] Remove debug spew. #89)
iOS and macOS versions for Mac Catalyst. ([src] Bump Touch.Unit dependency to get HttpTextWriter addition. #88)
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/02d6d05be3506c89a3b4fa8a8ceb7f33712a8f46..1e738e9f7f80e76e1f48690d1f95a7457ddead74