-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add support for selecting whether to create P/Invoke wrappers or not. Fixes #4940. #14961
Conversation
…s or not. Fixes xamarin#4940. * This is a potential mitigation for slower transition to native code when exception marshalling is enabled (xamarin#14812). * A minor modification was required in the linker, to make sure any modified assemblies are saved. Fixes xamarin#4940.
if (modified) { | ||
var action = Context.Annotations.GetAction (assembly); | ||
switch (action) { | ||
case AssemblyAction.Copy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you expecting more cases anytime soon or why choosing a switch for just one case?
You could avoid the nested if with if (modified && Context.Annotations.GetAction (assembly) == AssemblyAction.Copy) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified this a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1044.Monterey |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1023.Monterey' |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results17 tests failed, 132 tests passed.Failed tests
Pipeline on Agent XAMBOT-1044.Monterey |
Test failures are unrelated (#14943). |
…s or not. Fixes xamarin#4940. (xamarin#14961) * This is a potential mitigation for slower transition to native code when exception marshalling is enabled (xamarin#14812). * A minor modification was required in the linker, to make sure any modified assemblies are saved. Fixes xamarin#4940.
exception marshalling is enabled ([net6]
xamarin_get_frame_length
performance regression #14812).assemblies are saved.
Fixes #4940.