Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreSpotlight] Add support for xcode 15. #18918

Merged
merged 7 commits into from
Sep 12, 2023
Merged

[CoreSpotlight] Add support for xcode 15. #18918

merged 7 commits into from
Sep 12, 2023

Conversation

mandel-macaque
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Sep 5, 2023
View reviewed changes
src/corespotlight.cs Outdated
@@ -74,6 +74,10 @@ interface CSSearchableIndex {
[Export ("initWithName:protectionClass:")]
NativeHandle Constructor (string name, [NullAllowed] NSString protectionClass);

[iOS (9, 0), Mac (10, 11), MacCatalyst (13, 1), NoTV, NoWatch]
[Export ("initWithName:protectionClass:bundleIdentifier:options:")]
NativeHandle Constructor (string name, [NullAllowed] string protectionClass, string bundleIdentifier, nint options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like protectionClass can be a strongly typed enum:

https://developer.apple.com/documentation/corespotlight/cssearchableindex/4288306-initwithname?changes=latest_minor&language=objc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's add the enum

dalexsoto
dalexsoto requested changes Sep 5, 2023
View reviewed changes
src/corespotlight.cs Outdated
@@ -74,6 +74,10 @@ interface CSSearchableIndex {
[Export ("initWithName:protectionClass:")]
NativeHandle Constructor (string name, [NullAllowed] NSString protectionClass);

[iOS (9, 0), Mac (10, 11), MacCatalyst (13, 1), NoTV, NoWatch]
[Export ("initWithName:protectionClass:bundleIdentifier:options:")]
NativeHandle Constructor (string name, [NullAllowed] string protectionClass, string bundleIdentifier, nint options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's add the enum

dalexsoto
dalexsoto reviewed Sep 7, 2023
View reviewed changes
src/corespotlight.cs Outdated Show resolved Hide resolved
@mandel-macaque @dalexsoto
Update src/corespotlight.cs
7ffd25a 
Co-authored-by: Alex Soto <alex@alexsoto.me>
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2dd92c0da0628423573c1aa82e88214d9be29e9e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2dd92c0da0628423573c1aa82e88214d9be29e9e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2dd92c0da0628423573c1aa82e88214d9be29e9e [PR build]

@mandel-macaque mandel-macaque merged commit 905cf5f into xamarin:net8.0-xcode15 Sep 12, 2023
76 of 78 checks passed
@mandel-macaque mandel-macaque deleted the net8.0-xcode15-corespotlight branch September 12, 2023 17:45
@mandel-macaque mandel-macaque mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne