[msbuild] Update values we put in the generated Info.plist for Xcode archives. #20719

rolfbjarne · 2024-06-12T10:39:48Z

Set the Architectures array, which Xcode does. This requires passing RuntimeIdentifier(s)
to the task, so do that.
Set SchemeName, which Xcode does.

This is a partial fix for #20714.

…archives. * Don't set SolutionName/SolutionPath anymore. Xcode doesn't, and in any case we don't get the solution path when building MSBuild projects anyways, so we weren't setting these values to anything sensible (we'd get "*Undefined*" for some reason). * Set the Architectures array, which Xcode does. This requires passing RuntimeIdentifier(s) to the task, so do that. * Set SchemeName, which Xcode does. This is a partial fix for xamarin#20714.

emaf · 2024-06-17T15:22:51Z

msbuild/Xamarin.MacDev.Tasks/Tasks/Archive.cs


 				if (!string.IsNullOrEmpty (ProjectGuid))
 					arInfo.Add ("ProjectGuid", new PString (ProjectGuid));

 				if (!string.IsNullOrEmpty (ProjectTypeGuids))
 					arInfo.Add ("ProjectTypeGuids", new PString (ProjectTypeGuids));

-				if (!string.IsNullOrEmpty (SolutionPath)) {


@jstedfast I think SolutionName and SolutionPath is added for VS, so the Archive Manager can match this to the corresponding solution, right?

Correct. I was just about to comment on this!

@emaf @jstedfast I've added back SolutionName/SolutionPath now.

vs-mobiletools-engineering-service2 · 2024-06-17T19:05:12Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-06-17T19:21:55Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 3ee30dc417761f37730e0efbba30eb4395f195fd [PR build]

vs-mobiletools-engineering-service2 · 2024-06-17T19:25:55Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 3ee30dc417761f37730e0efbba30eb4395f195fd [PR build]

vs-mobiletools-engineering-service2 · 2024-06-17T19:26:16Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 3ee30dc417761f37730e0efbba30eb4395f195fd [PR build]

vs-mobiletools-engineering-service2 · 2024-06-17T19:26:35Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 3ee30dc417761f37730e0efbba30eb4395f195fd [PR build]

vs-mobiletools-engineering-service2 · 2024-06-17T19:45:50Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 3ee30dc417761f37730e0efbba30eb4395f195fd [PR build]

vs-mobiletools-engineering-service2 · 2024-06-18T08:50:49Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 168 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3ee30dc417761f37730e0efbba30eb4395f195fd [PR build]

rolfbjarne requested review from emaf and mauroa as code owners June 12, 2024 10:39

rolfbjarne linked an issue Jun 12, 2024 that may be closed by this pull request

MacCatalyst build on mac results in "Unknown Scheme", but iOS build working fine. #20714

Closed

Merge remote-tracking branch 'origin/main' into msbuild-archive-update

09d461a

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Jun 12, 2024

View reviewed changes

dalexsoto approved these changes Jun 13, 2024

View reviewed changes

Merge branch 'main' into msbuild-archive-update

a31689d

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits June 17, 2024 13:26

Limit to .NET.

4bdd37b

Merge remote-tracking branch 'origin/main' into msbuild-archive-update

c76ae30

This comment has been minimized.

Sign in to view

mauroa approved these changes Jun 17, 2024

View reviewed changes

emaf reviewed Jun 17, 2024

View reviewed changes

rolfbjarne added 2 commits June 17, 2024 19:26

Add back SolutionName/SolutionPath.

8af95cf

Merge remote-tracking branch 'origin/main' into msbuild-archive-update

3ee30dc

jstedfast approved these changes Jun 17, 2024

View reviewed changes

haritha-mohan approved these changes Jun 17, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 02e14e6 into xamarin:main Jun 25, 2024
27 checks passed

rolfbjarne deleted the msbuild-archive-update branch June 25, 2024 12:30

[msbuild] Update values we put in the generated Info.plist for Xcode archives. #20719

[msbuild] Update values we put in the generated Info.plist for Xcode archives. #20719

Conversation

rolfbjarne commented Jun 12, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

emaf Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

jstedfast Jun 17, 2024

Choose a reason for hiding this comment

rolfbjarne Jun 17, 2024

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jun 17, 2024

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Jun 17, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jun 17, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jun 17, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

vs-mobiletools-engineering-service2 commented Jun 17, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jun 17, 2024

💻 [CI Build] Windows Integration Tests passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne commented Jun 12, 2024 •

edited

Loading

emaf Jun 17, 2024 •

edited

Loading