[release/8.0.1xx-xcode15.1] [dotnet] Fix detecting if the interpreter is enabled. #20732
Conversation
The canonical property we use for the interpreter is `MtouchInterpreter` - and the interpreter is enabled if `MtouchInterpreter` is set to any value (the `MtouchInterpreter` value is used to select which assemblies to interpret, the only way to completely disable the interpreter is to not set `MtouchInterpreter` at all). So fix a couple of cases of wrong comparison: * Don't use `UseInterpreter` - which is used to compute a specific value for `MtouchInterpreter` - because developers don't have to set `UseInterpreter` to enable the interpreter, they can set `MtouchInterpreter` directly. * Don't compare `MtouchInterpreter` with `true`: that only checks if the assembly "true" is interpreted (which it rarely is). Fixes dotnet/runtime#96920.
…or not. Fixes #dotnet/runtime@101840. (xamarin#20563) (xamarin#20696) Dynamic code is not supported if the interpreter is not enabled, and the interpreter is not enabled if the MtouchInterpreter property is *empty*. This regression was introduced in xamarin#19812. Fixes dotnet/runtime#101840.
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 95 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
merged commit 6c1d0b0
into
xamarin:release/8.0.1xx-xcode15.1
The canonical property we use for the interpreter is
MtouchInterpreter- andthe interpreter is enabled if
MtouchInterpreteris set to any value (theMtouchInterpretervalue is used to select which assemblies to interpret, theonly way to completely disable the interpreter is to not set
MtouchInterpreterat all).So fix a couple of cases of wrong comparison:
UseInterpreter- which is used to compute a specific value forMtouchInterpreter- because developers don't have to setUseInterpreterto enable the interpreter, they can set
MtouchInterpreterdirectly.MtouchInterpreterwithtrue: that only checks if theassembly "true" is interpreted (which it rarely is).
Fixes dotnet/runtime#96920.
This is a backport of #19812 and #20696.