[release/9.0.1xx-rc1] Remove xcsync from SDK and install as .NET Global Tool #21127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 44b44a8)
mcumming
requested review from
dalexsoto and
rolfbjarne
and removed request for
rolfbjarne
This comment has been minimized.
This comment has been minimized.
Global tools are installed so that yuou can just run the tool command, it's on the path. Local tools need to be run using `dotnet {toolname}` or `dotnet tool run {toolname}`. Also change Message to an Error and add a Warning letting the use know the tool was installed and how to remove it.
(cherry picked from commit 26bc9af)
mcumming
changed the title
dalexsoto
approved these changes
Aug 27, 2024
mandel-macaque
approved these changes
Aug 27, 2024
rolfbjarne
approved these changes
Aug 27, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
(cherry picked from commit 74397a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the xcsync tool as an installed component of the SDK and uses it as a .NET Global Tool. The existing targets will continue to work, they will check if the tool is already installed, and if not, install it.
Backport from: #21126