-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild/dotnet] Add support for compressed xcframeworks in binding projects and as NativeReference items. Fixes #21294. #21492
[msbuild/dotnet] Add support for compressed xcframeworks in binding projects and as NativeReference items. Fixes #21294. #21492
Conversation
…rojects and as NativeReference items. Fixes #21294. Now it's possible to reference a compressed xcframework like this: ```xml <NativeReference Include="path/to/myframework.xcframework.zip" /> ``` This makes it easier to work with xcframeworks on Windows, because xcframeworks can contain symlinks, and by zipping them up the whole symlink problem is avoided. Turns out there's already a NuGet that adds a .xcframework.zip file as a NativeReference (Microsoft.ML.OnnxRuntime), so this makes that NuGet work. Fixes #21294. Fixes #21450.
|
✅ API diff for current PR / commit.NET (No breaking changes)✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 101 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Now it's possible to reference a compressed xcframework like this:
This makes it easier to work with xcframeworks on Windows, because
xcframeworks can contain symlinks, and by zipping them up the whole symlink
problem is avoided.
Turns out there's already a NuGet that adds a .xcframework.zip file as a
NativeReference (Microsoft.ML.OnnxRuntime), so this makes that NuGet work.
Fixes #21294.
Fixes #21450.