Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foundation] As a default, do not use the workaround in NSUrlSessionHandler for the threadpool. #8296

Merged
merged 1 commit into from
Apr 6, 2020

Commits on Apr 6, 2020

  1. [Foundation] As a default, do not use the workaround in NSUrlSessionH…

    …andler for thethreadpool.
    
    When an application was moved the the background, the thread pool from
    mono would be left in an unknonw state, making applications to stale
    (https://xamarin.github.io/bugzilla-archives/58/58633/bug.html#c7).
    
    This work was added in xamarin#5463
    
    We now set the default behaviour to skip the workaround to see if the
    new provided mono works as expected. We do not fully remove the
    workaround because we need some real world testing.
    
    If the new ThreadPool from mono does not work as expected we do provide
    a property to re-add the workaround. The BypassBackgroundSessionCheck
    can be set to false to allow users get it back.
    
    The following is an example usage of the API:
    
    ```csharp
    // create your own handler instance rather than using the one provided
    by default.
    var handler = new NSUrlSessionHandler() {
      BypassBackgroundSessionCheck = false, // readd the hack
    };
    var httpClient = new HttpClient (handler); // use the handler with the hack
    ```
    
    This is a partial fix for xamarin#7080
    mandel-macaque committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    ebc69a0 View commit details
    Browse the repository at this point in the history