Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Use correct relative path for install_name_tool on macOS #9804

Merged
merged 2 commits into from
Oct 8, 2020
Merged

[dotnet] Use correct relative path for install_name_tool on macOS #9804

merged 2 commits into from
Oct 8, 2020

Conversation

filipnavara
Copy link
Contributor

No description provided.

@filipnavara filipnavara mentioned this pull request Oct 7, 2020
Closed
6 tasks
@rolfbjarne rolfbjarne added macOS Issues affecting macOS community Community contribution ❤ dotnet An issue or pull request related to .NET (6) run-dotnet-tests Run all the .NET tests labels Oct 7, 2020
@spouliot spouliot added this to the .NET 6 milestone Oct 7, 2020
dalexsoto
dalexsoto approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Rolf's 👍

mandel-macaque
mandel-macaque approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after rolf commit is added.

@rolfbjarne
Copy link
Member

build

@monojenkins
Copy link
Collaborator

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@filipnavara
Copy link
Contributor Author

I'm working on a better fix for this problem. Looks like the .NET Core system libraries now have proper identity with @rpath prefix so the whole _UpdateDynamicLibraryId step could be removed. The LinkNativeCode however specifies incorrect -rpath for macOS builds so that still needs to be fixed.

This PR is still probably worth it as a stopgap solution and because of the removal of hard-coded MonoBundle from one place.

@rolfbjarne rolfbjarne merged commit 4f30a27 into xamarin:main Oct 8, 2020
@filipnavara filipnavara mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
community Community contribution ❤ dotnet An issue or pull request related to .NET (6) macOS Issues affecting macOS run-dotnet-tests Run all the .NET tests
Projects
None yet
Milestone
.NET 6
Development

Successfully merging this pull request may close these issues.
6 participants
@filipnavara @rolfbjarne @monojenkins @dalexsoto @spouliot @mandel-macaque