Skip to content

Commit

Permalink
validate all implemented
Browse files Browse the repository at this point in the history
more wiki documentation
fix for missing database search (null reference)
  • Loading branch information
xantari committed Jan 18, 2021
1 parent 09c3037 commit eed66db
Show file tree
Hide file tree
Showing 7 changed files with 72 additions and 56 deletions.
82 changes: 43 additions & 39 deletions PinCab.Configurator/AddEditGameForm.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions PinCab.Configurator/DatabaseBrowserForm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,10 @@ private void refreshDatabaseToolStripMenuItem_Click(object sender, EventArgs e)

private void dataGridViewEntryList_DataBindingComplete(object sender, DataGridViewBindingCompleteEventArgs e)
{
dataGridViewEntryList.AutoResizeColumns(DataGridViewAutoSizeColumnsMode.DisplayedCells);
if (e.ListChangedType != ListChangedType.Reset)
{
dataGridViewEntryList.AutoResizeColumns(DataGridViewAutoSizeColumnsMode.DisplayedCells);
}
//dataGridViewEntryList.FastAutoSizeColumns();
//var colSizes = WinformsExtensions.GetAutoSizeColumnsWidth(dataGridViewEntryList);
//WinformsExtensions.SetAutoSizeColumnsWidth(dataGridViewEntryList, colSizes);
Expand Down Expand Up @@ -512,7 +515,7 @@ private void dataGridViewEntryList_RowContextMenuStripNeeded(object sender, Data

private void dataGridViewChildEntries_DataBindingComplete(object sender, DataGridViewBindingCompleteEventArgs e)
{
dataGridViewEntryList.AutoResizeColumns(DataGridViewAutoSizeColumnsMode.DisplayedCells);
dataGridViewChildEntries.AutoResizeColumns(DataGridViewAutoSizeColumnsMode.DisplayedCells);
}

private void dataGridViewChildEntries_RowContextMenuStripNeeded(object sender, DataGridViewRowContextMenuStripNeededEventArgs e)
Expand Down Expand Up @@ -566,7 +569,7 @@ private void dataGridViewEntryList_SelectionChanged(object sender, EventArgs e)
{
var entry = GetActiveRowEntry();
//Now bind the child grid
bindingSourceChildEntries.DataSource = entry.RelatedEntries.ToSortableBindingList();
bindingSourceChildEntries.DataSource = entry?.RelatedEntries.ToSortableBindingList();
}

private void DatabaseBrowserForm_FormClosing(object sender, FormClosingEventArgs e)
Expand Down
18 changes: 9 additions & 9 deletions PinCab.Configurator/MainForm.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions PinCab.Configurator/MainForm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -613,8 +613,17 @@ private void writeB2sSettingsScreenrestxtToolStripMenuItem_Click(object sender,
private void validateallSettingsToolStripMenuItem_Click(object sender, EventArgs e)
{
helper.ClearMessages();
//TODO: Fill this in
MessageBox.Show("Not implemented yet.");

ValidateMonitorConfiguration();
helper.ValidatePinballX();
helper.ValidateB2sSettings();
helper.ValidateFutureDmd();
helper.ValidateUltraDmdSettings();
helper.ValidateDmdDeviceIniSettings();
helper.ValidateVpinMameDefaultKey();
helper.ValidatePinupPlayerSettings();
helper.ValidatePinballYSettings();
helper.WritePRocSettings(); //We don't write to P-ROC at this time, just echo the settings
}

private void b2SScreenresEditorToolStripMenuItem_Click(object sender, EventArgs e)
Expand Down Expand Up @@ -739,7 +748,7 @@ private void writepinballYSettingstxtToolStripMenuItem_Click(object sender, Even
private void validatepROCSettingsToolStripMenuItem1_Click(object sender, EventArgs e)
{
helper.ClearMessages();
helper.WritePRocSettings();
helper.WritePRocSettings(); //No validation available, we just write out the settings to apply to the text file
}

private void writepRocSettingsToolStripMenuItem_Click(object sender, EventArgs e)
Expand Down
4 changes: 2 additions & 2 deletions PinCab.Configurator/Utils/FormHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ public void WritePinballFxSettings()
{
var util = new PinballFxUtil();
var result = util.GetDisplayDetails(_displayDetails);
LogToolValidationResult("GetDisplayDetails", result);
LogToolValidationResult(PinballFxUtil.ToolName, result);
_txtData.Text += $"{PinballFxUtil.ToolName}: Write command completed.\r\n";
Log.Information($"{PinballFxUtil.ToolName}: Write command completed.");
}
Expand All @@ -369,7 +369,7 @@ public void WritePRocSettings()
{
var util = new ProcUtil();
var result = util.GetDisplayDetails(_displayDetails);
LogToolValidationResult("GetDisplayDetails", result);
LogToolValidationResult(ProcUtil.ToolName, result);
_txtData.Text += $"{ProcUtil.ToolName}: Write command completed.\r\n";
Log.Information($"{ProcUtil.ToolName}: Write command completed.");
}
Expand Down
Binary file added Screenshots/Wiki/MediaAudit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Screenshots/Wiki/PinballXFileMatching.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit eed66db

Please sign in to comment.