Review comments

xanzy · May 31, 2023 · 542beb6 · 542beb6
1 parent 948b6bf
commit 542beb6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/go.sum b/go.sum
@@ -43,6 +43,8 @@ google.golang.org/appengine v1.6.7 h1:FZR1q0exgwxzPzp/aF+VccGrSfxfPpkBqjIIEq3ru6
 google.golang.org/appengine v1.6.7/go.mod h1:8WjMMxjGQR8xUklV/ARdw2HLXBOI7O7uCIDZVag1xfc=
 google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw=
 google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc=
+google.golang.org/protobuf v1.29.0 h1:44S3JjaKmLEE4YIkjzexaP+NzZsudE3Zin5Njn/pYX0=
+google.golang.org/protobuf v1.29.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
 google.golang.org/protobuf v1.29.1 h1:7QBf+IK2gx70Ap/hDsOmam3GE0v9HicjfEdAxE62UoM=
 google.golang.org/protobuf v1.29.1/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=

diff --git a/protected_environments.go b/protected_environments.go
@@ -58,6 +58,7 @@ type EnvironmentAccessDescription struct {
 // GitLab API docs:
 // https://docs.gitlab.com/ee/api/protected_environments.html#protect-a-single-environment
 type EnvironmentApprovalRule struct {
+	ID                     int              `json:"id"`
 	UserID                 int              `json:"user_id"`
 	GroupID                int              `json:"group_id"`
 	AccessLevel            AccessLevelValue `json:"access_level"`

diff --git a/protected_environments_test.go b/protected_environments_test.go
@@ -57,7 +57,7 @@ func TestListProtectedEnvironments(t *testing.T) {
 		   "required_approvals": 2,
 		   "group_inheritance_type": 1
 		}
-	 ]
+	  ]
     },{
       "name":"*-release",
       "deploy_access_levels": [
@@ -138,7 +138,7 @@ func TestGetProtectedEnvironment(t *testing.T) {
 		   "required_approvals": 0,
 		   "group_inheritance_type": 0
 		}
-	 ]
+	  ]
     }`)
 	})
 
@@ -220,7 +220,7 @@ func TestProtectRepositoryEnvironments(t *testing.T) {
 		   "required_approvals": 0,
 		   "group_inheritance_type": 0
 		}
-	 ]
+	  ]
     }`)
 	})