This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
feat: add dependency list export client service #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmphil
changed the title
timofurrer
suggested changes
Nov 20, 2024
There was a problem hiding this comment.
@lmphil thanks for the contribution! I did a first round of review and left a couple of comments for you - back to you 🏓
timofurrer
suggested changes
Nov 21, 2024
There was a problem hiding this comment.
@lmphil thanks for the changes! I have some more additions - back to you 🏓
|
@timofurrer Done and tested. Thanks for the feedback. 🏓 |
lmphil
force-pushed
the
dependency-list
branch
from
faa3a8a to
a7ae7bd
Compare
timofurrer
suggested changes
Nov 21, 2024
There was a problem hiding this comment.
@lmphil I've left one last suggestion - then we are good for the merge.
Thanks for pulling through 🤝
timofurrer
approved these changes
Nov 21, 2024
|
I've actually applied the patch myself and will merge :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the GitLab Dependency List Export API:
https://docs.gitlab.com/ee/api/dependency_list_export.html