CA-371791: Fix world readable permissions on EXTSR #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileSR.attach modified to change the mount point permissions to 700. This prevents any non-root user from reading the contents of the SR. EXTSR.attach modified to call FileSR.attach. Other SRs could be changed to reuse FileSR.attach in the future. Unit tests added for FileSR to test old and new attach functionality. Signed-off-by: Kevin Lampis <klampis@cloud.com>
KevinLCtx
force-pushed
the
private/klampis/CA-371791_extsrperms
branch
from
3c8a171
to
5a54b00
Compare
MarkSymsCtx
approved these changes
Oct 18, 2023
TimSmithCtx
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSR.attach modified to change the mount point permissions to 700.
This prevents any non-root user from reading the contents of the SR.
EXTSR.attach modified to call FileSR.attach.
Other SRs could be changed to reuse FileSR.attach in the future.
Unit tests added for FileSR to test old and new attach functionality.
XenRT test in different PR.