CA-384030 Ignore awkardly named images in ISO SRs #652
Conversation
* Use os.listdir rather than util.listdir for finding images in an SMB share.
I don't really know why the latter exists, but I didn't want to get
side-tracked by the question of whether it could be eliminated or (if not)
how it should best handle non-ascii characters in filenames - especially as I
doubt that's ever an issue outside of ISOSR.py.
* Refactor the identification of images so that finding and filtering are in a
single function.
* When looking for image files in a mounted directory, ignore ones with
problematic names. This covers non-utf-8 names (which will always be a
problem, but that aren't likely to occur in this context), and names
that have had their utf-8 encodings mangled by Python's filesystem
encodings (which I'm anticipating will stop being a problem with Python
3.7 and later).
* When an ISO SR is being created, look to see if there are image files
with problematic names, but if there are create an alert message
rather than refuse to create the SR.
Signed-off-by: Robin Newton <robin.newton@cloud.com>
| "4", | ||
| "SR", | ||
| self.uuid, | ||
| "Ignored disk image file(s) due to" |
There was a problem hiding this comment.
Maybe this should include the num_images_ignored in the message?
There was a problem hiding this comment.
I was going to do that, but I didn't know how well that would play with message localization - given that XenCenter would presumably have to parse the message and then recreate a localized version of it.
There was a problem hiding this comment.
XC only supports English now, localization was removed
There was a problem hiding this comment.
Regardless. Messages should be internationalized.
There was a problem hiding this comment.
I wouldn't worry so much about the message text itself because the UI can always provide an override for it, but if we want the UI to show the number too, it would be useful to include it in the message in a form that the UI can parse it easily. For example, there are some messages with more complex info/more parameters that include the message body as xml - but this may be too much here. A simpler idea would be to use this message: N ignored disk image file(s) due to file name encoding issues, so the UI expects that the first word of this message is always the number, so it can fish it out easily.
Signed-off-by: Robin Newton robin.newton@cloud.com