CP-39600: Rework LVM locking to use fair lock queue #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSymsCtx
requested changes
Nov 29, 2023
TimSmithCtx
force-pushed
the
private/timsmi/CP-39600
branch
2 times, most recently
from
9bc8953 to
bd54b9f
Compare
MarkSymsCtx
previously approved these changes
Nov 29, 2023
rdn32
reviewed
Dec 1, 2023
rdn32
reviewed
Dec 1, 2023
TimSmithCtx
force-pushed
the
private/timsmi/CP-39600
branch
from
bd54b9f to
a85df50
Compare
rdn32
suggested changes
Dec 1, 2023
TimSmithCtx
force-pushed
the
private/timsmi/CP-39600
branch
2 times, most recently
from
2ec3127 to
28ba68c
Compare
rdn32
previously approved these changes
Dec 4, 2023
TimSmithCtx
force-pushed
the
private/timsmi/CP-39600
branch
from
28ba68c to
a32f13d
Compare
This is intended to prevent a storm of later LVM commands from usurping the lock that an earlier command is waiting for, just because they happened to manage to start waiting before the original holder was done. In some pathalogical circumstances, this has been known to result in a commant taking many minutes to get the lock. Signed-off-by: Tim Smith <tim.smith@cloud.com>
TimSmithCtx
force-pushed
the
private/timsmi/CP-39600
branch
from
a32f13d to
ffae900
Compare
MarkSymsCtx
approved these changes
Dec 5, 2023
rdn32
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to prevent a storm of later LVM commands from usurping the lock that an earlier command is waiting for, just because they happened to manage to start waiting before the original holder was done.
In some pathalogical circumstances, this has been known to result in a commant taking many minutes to get the lock.