Always remove the RO/RW tag from VDIs in case of failure #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSymsCtx
approved these changes
Feb 6, 2024
rdn32
reviewed
Feb 6, 2024
drivers/blktap2.py
Outdated
| @@ -1615,7 +1617,6 @@ def _activate_locked(self, sr_uuid, vdi_uuid, options): | |||
| driver_info = target.sr.srcmd.driver_info | |||
There was a problem hiding this comment.
These few lines of code used to be conditional on self.tap_wanted() but now they're run unconditionally. Is that deliberate? Or an accidental side-effect of the way you've moved the beginning of the try block?
There was a problem hiding this comment.
well spotted, that's a bug
There was a problem hiding this comment.
I pushed this change a little too quickly... So fixed I guess this time. :)
MarkSymsCtx
requested changes
Feb 6, 2024
drivers/blktap2.py
Outdated
| @@ -1615,7 +1617,6 @@ def _activate_locked(self, sr_uuid, vdi_uuid, options): | |||
| driver_info = target.sr.srcmd.driver_info | |||
There was a problem hiding this comment.
well spotted, that's a bug
Wescoeur
force-pushed
the
fix-pause-tag-never-removed
branch
from
ef7a9b9 to
b1533b5
Compare
rdn32
approved these changes
Feb 6, 2024
|
Being picky it's not actually the |
MarkSymsCtx
approved these changes
Feb 6, 2024
During VDI activation in the blktap module and in case of failure in "sm.VDI.from_uuid" call, the RW/RO tag is never removed. As a result a VDI can no longer be used correctly: an assert is triggered each time we try to re-activate this volume because the tag is still present. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur
force-pushed
the
fix-pause-tag-never-removed
branch
from
b1533b5 to
05b947b
Compare
Wescoeur
changed the title
|
Right. I modified the description. |
TimSmithCtx
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During VDI activation in the blktap module and in case of failure in "sm.VDI.from_uuid" call, the RO/RW tag is never removed. As a result a VDI can no longer be used correctly: an assert is triggered each time we try to re-activate this volume because the tag is still present.