Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-47841: update multipath configuration for PURE Storage #676

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

MarkSymsCtx
Copy link
Contributor

No description provided.

Signed-off-by: Mark Syms <mark.syms@citrix.com>
@@ -142,4 +142,17 @@ devices {
failback immediate
no_path_retry 18
}
device {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this configuration come from?

It looks similar to but not the same as the upstream built in configuration:

        {
                /* FlashArray */
                .vendor        = "PURE",
                .product       = "FlashArray",
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
                .hwhandler     = "1 alua",
                .prio_name     = PRIO_ALUA,
                .fast_io_fail  = 10,
                .max_sectors_kb = 4096,
        },

In particular, it is missing the max_sectors_kb which is explicitly called out in the commit message:

commit 95030d2c11a12c186e5ded3239dc05973f9359c8
Author: Brian Bunker <brian@purestorage.com>
Date:   Mon Mar 2 15:53:54 2020 +0100

    ALUA support for PURE FlashArray

    Hello all,

    It has been some time since we updated our PURE FlashArray
    configuration. The Linux vendors that we had been seeing in the field
    were using very old versions of multipath-tools, so we haven’t needed to
    change anything for some time. With the release of RHEL8, some of our
    earlier values have been lost by upstream changes.

    In addition we have our Active Cluster feature which leverages ALUA
    since our last patch. The ALUA confguration will work for all
    FlashArrays with or without Active Cluster.

    We are changing 3 things.

    1. ALUA support
    2. Fast fail timeout from the default of 5 seconds to 10 seconds (We
       need this for our FC NPIV port migration).
    3. Maximum sector size of 4MB. Some Linux vendors don’t honor the block
       limits VPD page of INQUIRY).
...

(unless it is relying on defaults set somewhere?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkSymsCtx MarkSymsCtx merged commit 5ebbc1f into xapi-project:master Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants