CA-392823: ensure no device mapper conflicts in LVHDSR detach #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the detach operation checks are made that none of the device mapper devices for the SR volume group have opern handles. The falls false if operations on other LVM srs happen to call a device mapper operation such as `lvs` or `vgs` at the point the check is made as these operations can result in all of the devices managed by the device mapper subsystem being accessed as part of the scan. this then gives a false response for the open file handles check. Signed-off-by: Mark Syms <mark.syms@cloud.com>
TimSmithCtx
previously approved these changes
May 13, 2024
KevinLCtx
previously approved these changes
May 13, 2024
Signed-off-by: Mark Syms <mark.syms@cloud.com>
KevinLCtx
approved these changes
May 16, 2024
TimSmithCtx
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the detach operation checks are made that none of the device mapper devices for the SR volume group have opern handles. The falls false if operations on other LVM srs happen to call a device mapper operation such as
lvsorvgsat the point the check is made as these operations can result in all of the devices managed by the device mapper subsystem being accessed as part of the scan. this then gives a false response for the open file handles check.