Ca 390937: fix conflicts between GC and SR detach #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoind inheriting locks and open files through a fork start the GC cleanup script as a standalone process. Signed-off-by: Mark Syms <mark.syms@cloud.com>
Doing the cleanupCache before acquiring the locks can result in a failure, in particular as part of XenCert where an sr_detach operation attempts to abort GC but the GC is not registered as running and then the umount of NFS fails as the cache cleanup still has the directory open. Also check for the SR still being attached after the active lock has been acquired. Signed-off-by: Mark Syms <mark.syms@cloud.com>
MarkSymsCtx
requested review from
rdn32,
rosslagerwall,
TimSmithCtx and
KevinLCtx
KevinLCtx
approved these changes
May 22, 2024
TimSmithCtx
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.