Split PR20 for better review: Make URLopener and xmlrpc compatible #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin9390
approved these changes
Dec 5, 2023
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Commit message and a minor change to make it work by Bernhard Kaindl. Committed code by Qin Zhang. Tested on xs8 with: - Python2: python-pam-0.1.4-1.el7.noarch - Python3: python3-pam-1.8.4-1.xs8.noarch Co-authored-by: Bernhard Kaindl <bernhard.kaindl@cloud.com> Signed-off-by: Qin Zhang （张琴） <qin.zhang@citrix.com> Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
GeraldEV
approved these changes
Dec 6, 2023
bernhardkaindl
force-pushed
the
safe_pr20-import-URLopener-and-xmlrpc
branch
from
f12540b to
a9cff18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits, tested for py2 and py3:
python-pamurllib.URLopener,xmlrpclib,SocketServerandSimpleXMLRPCServerIn #18 (comment), Andrew (on the thread to not make the code more complicated) gave the direction to split the changes into two categories, with Python2/compatible changes to go into a Python2-compatible master first:
This would be the second to last PR on that, as it is easy (not complicated) to not break Python2 with this update, which would mean we would not have to fork the code into Py2/Py3 now.