Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of __cmp__ and use __eq__ instead #25

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Dec 4, 2023

According to the agreement with Andrew at #18 (comment), Python2-compatible changes can go to the master branch freely, before branching of the Python3-only changes into a py3 branch:

So, please can we collect together all commits which are py2-safe fixes, which can get reviewed and merged freely, and please keep all commits which break compatibility with py2 in a separate single PR so it can be merged all in one go. The final commit on the py3 branch should bump the major version number of xsconsole seeing as its a bit step change.

Qin Zhang (张琴)authored this commit and I reviewed it:

  • The __hash__ function (needed in addition to eq for Python3's datamodel) is already in the code, so this change is fine for Py2 and Py3

Signed-off-by: Qin Zhang (张琴) <qin.zhang@citrix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants