Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allen-brain user story by @jsiegle #470

Merged
merged 13 commits into from
Mar 29, 2023

Conversation

jhamman
Copy link
Contributor

@jhamman jhamman commented Mar 7, 2023

towards: #344

cc @jsiegle

@vercel
Copy link

vercel bot commented Mar 7, 2023

@jhamman is attempting to deploy a commit to the xarray Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
xarray-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 2:54PM (UTC)

@jhamman
Copy link
Contributor Author

jhamman commented Mar 7, 2023

@andersy005 - any ideas why this is failing to build?

Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
@jhamman jhamman changed the title add all-brain user story by @jsiegle add allen-brain user story by @jsiegle Mar 8, 2023
@jhamman
Copy link
Contributor Author

jhamman commented Mar 27, 2023

@jsiegle - I (finally) added the figures here and updated the publish date to this Wednesday. Would you mind giving this a final read through? The preview is here: https://xarray-9qf77ibqu-xarray.vercel.app/blog/xarray-for-neurophysiology

@andersy005, @dcherian, or @TomNicholas - can we get one additional proof read on this?

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 @jhamman & @jsiegle, thank you for this addition! i left some comments/suggestions (mostly code formatting)

src/posts/xarray-for-neurophysiology/index.md Outdated Show resolved Hide resolved
src/posts/xarray-for-neurophysiology/index.md Outdated Show resolved Hide resolved
src/posts/xarray-for-neurophysiology/index.md Outdated Show resolved Hide resolved
src/posts/xarray-for-neurophysiology/index.md Outdated Show resolved Hide resolved
@TomNicholas
Copy link
Member

This looks great! I only have two small comments:

  1. It would be nice to explain the relationship between the session class and xarray objects earlier. Currently it's a bit confusing how you create this unfamiliar class, call some functions on it, and then somehow end up in xarray-land. Just a quick statement like "session objects hold all the information about our experiment, including X data which is stored in a wrapped xarray.Dataset".

  2. There are some figures which it's implied are produced directly from the given code, but I'm pretty sure aren't, because they have extra annotations. (e.g. "flash stimulus on screen" or "onset response".) Maybe add a figure caption explaining this? Or just use the actual raw figure that would be produced by that code.

jhamman and others added 3 commits March 27, 2023 15:54
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
Co-authored-by: Anderson Banihirwe <13301940+andersy005@users.noreply.github.com>
@jsiegle
Copy link
Contributor

jsiegle commented Mar 28, 2023

Here are some edits that address @TomNicholas' suggestions: jsiegle@b5f5ee0

@jhamman jhamman merged commit 4ae9d4d into xarray-contrib:main Mar 29, 2023
@jhamman
Copy link
Contributor Author

jhamman commented Mar 29, 2023

Thanks again for writing this up @jsiegle! It's live here: https://xarray.dev/blog/xarray-for-neurophysiology

@jsiegle
Copy link
Contributor

jsiegle commented Mar 29, 2023

No problem, it was fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants