-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebook to reflect the most recent changes #114
Conversation
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
===========================================
+ Coverage 97.97% 100.00% +2.02%
===========================================
Files 5 5
Lines 198 192 -6
Branches 35 35
===========================================
- Hits 194 192 -2
+ Misses 4 0 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andersy005, thanks for submitting these changes!
Rather than manually updating the notebook to account for changes, I think it would be better to execute the notebook when building the docs through nbsphinx. In addition to automatically keeping it up to date and reducing the number of blob objects in the git history, that should allow us to notice breaking changes easier.
I see that you've made some helpful changes to the cell contents in addition to updating the output. Do you mind clearing the outputs from the notebook, so that we can merge in those changes? I can configure nbsphinx to execute the notebook as a separate PR.
Sounds good @maxrjones I'm going to push the changes shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Anderson!
Description of proposed changes
Fixes #