Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Dataset to dict approximately following CF-JSON specification #37

Merged
merged 10 commits into from
Feb 23, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented Feb 8, 2023

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Added a method exporting the Dataset object to a dict. I tried to follow the CF-JSON spec as much as possible, but since Dataset is also used to describe NcML aggregations, the spec cannot be enforced very strictly (missing info).

Fixes #31

@huard huard requested a review from andersy005 February 8, 2023 16:15
@huard
Copy link
Collaborator Author

huard commented Feb 14, 2023

@aulemahal Could you do a quick review ?

@huard huard requested a review from aulemahal February 14, 2023 20:46
xncml/core.py Outdated Show resolved Hide resolved
xncml/core.py Outdated Show resolved Hide resolved
xncml/core.py Show resolved Hide resolved
@huard huard merged commit 95d8414 into main Feb 23, 2023
@huard huard deleted the fix-31 branch February 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support export of Dataset to CF-JSON
2 participants